zsh-workers
 help / color / mirror / code / Atom feed
From: "Mikael Magnusson" <mikachu@gmail.com>
To: zsh-workers <zsh-workers@sunsite.dk>
Subject: Re: Fix a typo in _git.
Date: Tue, 19 Aug 2008 02:09:38 +0200	[thread overview]
Message-ID: <237967ef0808181709m1f6d6c5ao2311d960284f5c3f@mail.gmail.com> (raw)
In-Reply-To: <20080818224510.GA12825@scru.org>

Oooh, that was tricky :).

2008/8/19 Clint Adams <clint@zsh.org>:
> On Mon, Aug 18, 2008 at 10:10:40PM +0200, Mikael Magnusson wrote:
>> Now that I actually rebased my stuff on top of latest cvs, and include
>> _call_program, I notice what I think is the reason I removed it: It
>> doesn't work. Does it work for you? It's kind of weird, all the other
>> _call_program in _git work fine, just the three git for-each-ref don't.
>> And they work fine with the _call_program \S+ removed...
>
> Oops.
>
> Index: Completion/Unix/Command/_git
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
> retrieving revision 1.78
> diff -u -r1.78 _git
> --- Completion/Unix/Command/_git        18 Aug 2008 01:55:29 -0000      1.78
> +++ Completion/Unix/Command/_git        18 Aug 2008 22:43:19 -0000
> @@ -2972,7 +2972,7 @@
>   local expl
>   declare -a branch_names
>
> -  branch_names=(${${(f)"$(_call_program headrefs git for-each-ref --format='%(refname)' refs/heads refs/remotes 2>/dev/null)"}#refs/(heads|remotes)/})
> +  branch_names=(${${(f)"$(_call_program headrefs git for-each-ref --format='"%(refname)"' refs/heads refs/remotes 2>/dev/null)"}#refs/(heads|remotes)/})
>   __git_command_successful || return
>
>   _wanted heads expl branch-name compadd $* - $branch_names HEAD
> @@ -2983,7 +2983,7 @@
>   local expl
>   declare -a tag_names
>
> -  tag_names=(${${(f)"$(_call_program tagrefs git for-each-ref --format='%(refname)' refs/tags 2>/dev/null)"}#refs/tags/})
> +  tag_names=(${${(f)"$(_call_program tagrefs git for-each-ref --format='"%(refname)"' refs/tags 2>/dev/null)"}#refs/tags/})
>   __git_command_successful || return
>
>   _wanted tags expl tag-name compadd $* - $tag_names
> @@ -3036,7 +3036,7 @@
>   local expl
>   declare -a branch_names
>
> -  branch_names=(${${(f)"$(_call_program branchrefs git for-each-ref --format='%(refname)' refs/heads 2>/dev/null)"}#refs/heads/})
> +  branch_names=(${${(f)"$(_call_program branchrefs git for-each-ref --format='"%(refname)"' refs/heads 2>/dev/null)"}#refs/heads/})
>   __git_command_successful || return
>
>   _wanted branch-names expl branch-name compadd $* - $branch_names

-- 
Mikael Magnusson


  reply	other threads:[~2008-08-19  0:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 23:56 Mikael Magnusson
2008-08-16  0:45 ` Clint Adams
2008-08-16 12:56 ` Clint Adams
2008-08-16 13:25 ` Clint Adams
2008-08-16 13:55 ` Clint Adams
2008-08-16 16:15 ` Clint Adams
2008-08-16 17:59 ` Clint Adams
2008-08-16 18:29 ` Clint Adams
2008-08-17 14:03 ` Clint Adams
2008-08-17 17:13 ` Clint Adams
2008-08-17 17:27   ` Mikael Magnusson
2008-08-18  1:46     ` Clint Adams
2008-08-18  9:47       ` Mikael Magnusson
2008-08-18 20:10         ` Mikael Magnusson
2008-08-18 22:45           ` Clint Adams
2008-08-19  0:09             ` Mikael Magnusson [this message]
2008-08-19  0:25               ` Clint Adams
2008-08-19  0:37                 ` Mikael Magnusson
2008-08-19  0:39                   ` Mikael Magnusson
2008-08-19  0:58                   ` Clint Adams
2008-08-19  1:05                   ` Clint Adams
2008-08-17 23:23 ` Mikael Magnusson
2008-08-17 23:30   ` Mikael Magnusson
2008-08-18  0:08     ` Phil Pennock
2008-08-19  1:08 ` Clint Adams
2008-08-19  1:41 ` Clint Adams
  -- strict thread matches above, loose matches on Subject: below --
2007-10-18 21:23 Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237967ef0808181709m1f6d6c5ao2311d960284f5c3f@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).