From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19136 invoked from network); 19 Aug 2008 00:10:04 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 19 Aug 2008 00:10:04 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 77038 invoked from network); 19 Aug 2008 00:09:56 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 19 Aug 2008 00:09:56 -0000 Received: (qmail 16794 invoked by alias); 19 Aug 2008 00:09:44 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25481 Received: (qmail 16776 invoked from network); 19 Aug 2008 00:09:42 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 19 Aug 2008 00:09:42 -0000 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by bifrost.dotsrc.org (Postfix) with ESMTP id 636668058F37 for ; Tue, 19 Aug 2008 02:09:39 +0200 (CEST) Received: by nf-out-0910.google.com with SMTP id g13so3163626nfb.11 for ; Mon, 18 Aug 2008 17:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=Gd6OYiq6FQcGwHuDRThDEZ3Odd9j4DveS9RqPjBvBq0=; b=GCnz8cQjDYsZHYmHZWlAYI0kiMdIZipJUHiozewN71xvVnaLC9jQ8sti+Q+Y4xuiHF 9wMSnJOFBp+0Ili6pQpf4E/I1fSdZaqWNzDyJ8ncZvO1vNv3NPv4BgTxHHoxt1W0fzRm m6YPBxn1Bs4RWhoJvGKvwDmnXVtgSM84EVTnw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=f6h/TpIS04lSN9UBvVoQNruVNy44ybZLVaNcTwkeb2EjoeZLMF90w6j6FiGIVOvnHA gY/pabPc41vOt3ZkCLFfz8Q4bpN/Fnk/IKnAF7OvsYtUspc/B77qqxX2IGBWj4OlAc4i X0FIbCBpk/j9+Lipnl5qE/J/4rPXO0yN12LVg= Received: by 10.210.125.13 with SMTP id x13mr8828980ebc.191.1219104578879; Mon, 18 Aug 2008 17:09:38 -0700 (PDT) Received: by 10.210.19.20 with HTTP; Mon, 18 Aug 2008 17:09:38 -0700 (PDT) Message-ID: <237967ef0808181709m1f6d6c5ao2311d960284f5c3f@mail.gmail.com> Date: Tue, 19 Aug 2008 02:09:38 +0200 From: "Mikael Magnusson" To: zsh-workers Subject: Re: Fix a typo in _git. In-Reply-To: <20080818224510.GA12825@scru.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <237967ef0808151656j7787f169g4b3456910e05bfc2@mail.gmail.com> <20080817171321.GA24334@scru.org> <237967ef0808171027t4773ff36nb1cfe08942b63a5f@mail.gmail.com> <20080818014613.GA30193@scru.org> <237967ef0808180247l7b0ed485ob72df0a0637c57e9@mail.gmail.com> <237967ef0808181310kfa7128bt2e0321e77ad96d8f@mail.gmail.com> <20080818224510.GA12825@scru.org> X-Virus-Scanned: ClamAV 0.92.1/8056/Mon Aug 18 16:33:41 2008 on bifrost X-Virus-Status: Clean Oooh, that was tricky :). 2008/8/19 Clint Adams : > On Mon, Aug 18, 2008 at 10:10:40PM +0200, Mikael Magnusson wrote: >> Now that I actually rebased my stuff on top of latest cvs, and include >> _call_program, I notice what I think is the reason I removed it: It >> doesn't work. Does it work for you? It's kind of weird, all the other >> _call_program in _git work fine, just the three git for-each-ref don't. >> And they work fine with the _call_program \S+ removed... > > Oops. > > Index: Completion/Unix/Command/_git > =================================================================== > RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v > retrieving revision 1.78 > diff -u -r1.78 _git > --- Completion/Unix/Command/_git 18 Aug 2008 01:55:29 -0000 1.78 > +++ Completion/Unix/Command/_git 18 Aug 2008 22:43:19 -0000 > @@ -2972,7 +2972,7 @@ > local expl > declare -a branch_names > > - branch_names=(${${(f)"$(_call_program headrefs git for-each-ref --format='%(refname)' refs/heads refs/remotes 2>/dev/null)"}#refs/(heads|remotes)/}) > + branch_names=(${${(f)"$(_call_program headrefs git for-each-ref --format='"%(refname)"' refs/heads refs/remotes 2>/dev/null)"}#refs/(heads|remotes)/}) > __git_command_successful || return > > _wanted heads expl branch-name compadd $* - $branch_names HEAD > @@ -2983,7 +2983,7 @@ > local expl > declare -a tag_names > > - tag_names=(${${(f)"$(_call_program tagrefs git for-each-ref --format='%(refname)' refs/tags 2>/dev/null)"}#refs/tags/}) > + tag_names=(${${(f)"$(_call_program tagrefs git for-each-ref --format='"%(refname)"' refs/tags 2>/dev/null)"}#refs/tags/}) > __git_command_successful || return > > _wanted tags expl tag-name compadd $* - $tag_names > @@ -3036,7 +3036,7 @@ > local expl > declare -a branch_names > > - branch_names=(${${(f)"$(_call_program branchrefs git for-each-ref --format='%(refname)' refs/heads 2>/dev/null)"}#refs/heads/}) > + branch_names=(${${(f)"$(_call_program branchrefs git for-each-ref --format='"%(refname)"' refs/heads 2>/dev/null)"}#refs/heads/}) > __git_command_successful || return > > _wanted branch-names expl branch-name compadd $* - $branch_names -- Mikael Magnusson