From: "Mikael Magnusson" <mikachu@gmail.com>
To: "zsh workers" <zsh-workers@sunsite.dk>
Subject: Re: PATCH: Fix a bug in _git's clone completion
Date: Thu, 28 Aug 2008 20:04:14 +0200 [thread overview]
Message-ID: <237967ef0808281104g1b22c705s662f4f17d8db0b5a@mail.gmail.com> (raw)
In-Reply-To: <20080828160152.GE6330@fsst.voodoo.lan>
2008/8/28 Frank Terbeck <ft@bewatermyfriend.org>:
> There was a backslash missing at a line end, which screwed up things.
>
> Also, I don't understand the completion after 'git clone --bare <tab>'.
> It does not give me *any* completions, while I would expect the same
> completions as without the --bare option.
>
> If I do 'git clone --bare -<tab>', I only get a small subset of the
> remaining options. I don't know what is happening here.
No idea here...
> Finally, I do not understand why the end of the _arguments call was
> done like this:
>
> [snip]
> ':repository:__git_any_repositories' \-
> '*:directory:_directories' && ret=0-
> [snap]
>
> ...and not just: '*:repository:__git_any_repositories' && ret 0
>
> If someone can explain, please do ahead. :)
This is because
SYNOPSIS
git clone ... <repository> [<directory>]
Ie, you can give an optional argument where to clone to. The * is bogus
though.
diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index d6cda20..4a50b39 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -1611,14 +1611,14 @@ _git-clean () {
'*:file:_files' && ret=0
}
-# TODO: The --no-checkout is undocumented.
(( $+functions[_git-clone] )) ||
_git-clone () {
- _arguments \
+ _arguments -S \
'--bare[make a bare GIT repository]' \
+ '--mirror[clone refs into refs/* instead of refs/remotes/origin/*]' \
'(-l --local)'{-l,--local}'[perform a local cloning of a repository]' \
- '(-s --shared)'{-s,--shared}'[share the objects with the source
repository (warning: see man page)]' \
+ '(-s --shared)'{-s,--shared}'[share the objects with the source
repository (warning: see man page)]' \
'--reference[reference repository]:repository:_directories' \
'(-q --quiet)'{-q,--quiet}'[operate quietly]' \
'(-n --no-checkout)'{-n,--no-checkout}'[do not checkout HEAD
after clone is complete]' \
@@ -1628,7 +1628,7 @@ _git-clone () {
$template_arg \
'--depth[create a shallow clone, given number of revisions deep]:
:_guard "[[\:digit\:]]##" depth' \
':repository:__git_any_repositories' \
- '*:directory:_directories' && ret=0
+ ':directory:_directories' && ret=0
}
(( $+functions[_git-commit] )) ||
--
Mikael Magnusson
next prev parent reply other threads:[~2008-08-28 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 16:01 Frank Terbeck
2008-08-28 18:04 ` Mikael Magnusson [this message]
2008-08-28 18:37 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237967ef0808281104g1b22c705s662f4f17d8db0b5a@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).