From: Mikael Magnusson <mikachu@gmail.com>
To: zsh-workers@sunsite.dk
Subject: Re: Getting the CVS revision of Zsh
Date: Wed, 14 Jan 2009 19:54:02 +0100 [thread overview]
Message-ID: <237967ef0901141054y35a4fafdpade3134bc49f69aa@mail.gmail.com> (raw)
In-Reply-To: <090114085737.ZM18662@torch.brasslantern.com>
2009/1/14 Bart Schaefer <schaefer@brasslantern.com>:
> On Jan 14, 2:33pm, Richard Hartmann wrote:
> }
> } My suggestion would be to introduce a new variable called
> } $ZSH_RELEASE which is only filled if the source zsh was
> } compiled from is tagged as a release.
> }
> } Thoughts?
>
> My thought is that all of this, including ZSH_PATCHLEVEL, should
> never have been bothered with in the first place.
>
> Either you're compiling zsh from source yourself, in which case you
> should know what you're compiling; or you're using a package that was
> installed by somebody else, in which case it's between you and that
> somebody if you're having bleeding-edge non-releases forced on you.
>
> If you're a packager like Debian or RedHat who occasionally ports
> individual patches backwards or sideways or makes your own stability
> patches, anything in these variables is going to be either wrong and
> misleading to the end user or fabricated and meaningless to the zsh
> developers upstream.
>
> I was holding my tongue on ZSH_PATCHLEVEL despite my annoyance that
> it uses the RCS $Revision: tag -- I mirror the zsh sources into my
> own local repository, which means that tag gets rewritten whenever
> I do a check-in, so my local build will rarely if ever match the
> "real thing", hence it's useless cruft to me -- and I suppose it's
> up to PWS if he wants to jump through the hoops to make something
> like this appear to work, but I'm completely unconvinced by the
> argument that they're in some way beneficial.
FWIW, I use a git import which doesn't do any keyword expansion, so
the define is empty in my case, which obviously breaks the build. I
don't know if you want to a) not care b) add some #ifdef to set it to
"unknown" or such or c) add some shell code for git to set it.
If b or c I can construct a patch.
--
Mikael Magnusson
next prev parent reply other threads:[~2009-01-14 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2d460de70901090301h6b309a7cm19c5ebfec989ff2c@mail.gmail.com>
[not found] ` <200901091121 .n09BLVvZ006382@news01.csr.com>
[not found] ` <200901091121.n09BLVvZ006382@news01.csr.com>
[not found] ` <2d460de70901090348t3ea9e25fi29a7165ee42ae5e5@mail.gmail.com>
[not found] ` <200901091158.n09BwPii006839@news01.csr.com>
[not found] ` <2d460de7090 1090441i7ef1795bs42ed98fe0f33c9ba@mail.gmail.com>
[not found] ` <200901091258.n09CwS7T007 471@news01.csr.com>
[not found] ` <2d460de70901090441i7ef1795bs42ed98fe0f33c9ba@mail.gmail.com>
[not found] ` <200901091258.n09CwS7T007471@news01.csr.com>
[not found] ` <2d460de70901090507i7c3179e4u1e2def459f214566@mail.gmail.com>
2009-01-09 20:13 ` Peter Stephenson
2009-01-09 22:33 ` Richard Hartmann
2009-01-10 21:43 ` Peter Stephenson
2009-01-13 5:25 ` Jun T.
2009-01-13 10:09 ` Peter Stephenson
2009-01-14 3:48 ` Jun T.
[not found] ` <2d460de70901140533icf13f94yc7f63f974b236f45@mail.gmail.com>
[not found] ` <090114085737.ZM18662@torch.brasslantern.com>
2009-01-14 17:22 ` Peter Stephenson
2009-01-14 23:36 ` Clint Adams
2009-01-15 14:38 ` Peter Stephenson
2009-01-14 18:54 ` Mikael Magnusson [this message]
2009-01-15 19:43 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237967ef0901141054y35a4fafdpade3134bc49f69aa@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).