From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8840 invoked from network); 29 Jan 2009 14:40:48 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 29 Jan 2009 14:40:48 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 13161 invoked from network); 29 Jan 2009 14:40:43 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 29 Jan 2009 14:40:43 -0000 Received: (qmail 14505 invoked by alias); 29 Jan 2009 14:40:40 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26478 Received: (qmail 14492 invoked from network); 29 Jan 2009 14:40:39 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 29 Jan 2009 14:40:39 -0000 Received: from mail-ew0-f20.google.com (mail-ew0-f20.google.com [209.85.219.20]) by bifrost.dotsrc.org (Postfix) with ESMTP id 95F5D80271F0 for ; Thu, 29 Jan 2009 15:40:36 +0100 (CET) Received: by ewy13 with SMTP id 13so4056611ewy.21 for ; Thu, 29 Jan 2009 06:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=eAmffThQ1a3lG66Ah3ICnHkwhiWTq1PJE7yAWp+pbkk=; b=m9RYle2LYcAO2tihcwC8Qdq5p9eOwvkLRqH5rOSiFT4djyQwzAJfK0+VGHwPD0CLoP anmhqsJsZ1rbftRDzf1Y3iXznbIus7J01oS9D6p9upaAp/qwx70oP2t5V0hNupAjWJmZ J7ZQejJzqUpgkilBLdZfgKaWJ/zQPSjj1ctC4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=cY7VYhoWnPcP9vui1KlgZ9srFHWpmZHt3a2feXgDtd4nrfekTGeoNGd0n1SKsesmPe AlqERnabHKrwcjUB5hph9f1ldUhxmyoVLv44EeVhWKmooZCwUrpjFVu1UHhWWAQj8KSq 1TjBKRbIcgtvrJzl0lwc04Ds1BKX7uwjV+iUk= MIME-Version: 1.0 Received: by 10.210.58.13 with SMTP id g13mr125244eba.196.1233240036106; Thu, 29 Jan 2009 06:40:36 -0800 (PST) In-Reply-To: <2d460de70901290636g6e0b43fw971397716cba8886@mail.gmail.com> References: <1233231710-1204-1-git-send-email-ingmar@exherbo.org> <2d460de70901290636g6e0b43fw971397716cba8886@mail.gmail.com> Date: Thu, 29 Jan 2009 15:40:36 +0100 Message-ID: <237967ef0901290640u9adf073g204586c1b290d0@mail.gmail.com> Subject: Re: [PATCH] Updates to git completion From: Mikael Magnusson To: Richard Hartmann Cc: Ingmar Vanhassel , "Zsh Hackers' List" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.92.1/8919/Thu Jan 29 14:05:38 2009 on bifrost X-Virus-Status: Clean 2009/1/29 Richard Hartmann : > On Thu, Jan 29, 2009 at 13:21, Ingmar Vanhassel wrote: > >> I've started working on updating the git completion for command line >> changes in git 1.6.0 & newer. > > Ah, sorry, I should have read all emails on this list before answering. > > First of all: Thanks & welcome :) > > > If you are adding/changing things which are not valid for older versions > of git, you might want to check the git version and act depending on > that. > From looking over the patches (_not_ trying them!), they seem to > make sense (provided that git has those options ;) I think trying to complete options for the right versions for ~130 commands could make the code just a bit convoluted and hard to follow. Not even git itself documents when options were introduced. -- Mikael Magnusson