From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23133 invoked from network); 3 Mar 2009 17:00:17 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 3 Mar 2009 17:00:17 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 50632 invoked from network); 3 Mar 2009 17:00:12 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 3 Mar 2009 17:00:12 -0000 Received: (qmail 28442 invoked by alias); 3 Mar 2009 17:00:06 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26674 Received: (qmail 28422 invoked from network); 3 Mar 2009 17:00:05 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 3 Mar 2009 17:00:05 -0000 Received: from mail-ew0-f172.google.com (mail-ew0-f172.google.com [209.85.219.172]) by bifrost.dotsrc.org (Postfix) with ESMTP id 673208058F82 for ; Tue, 3 Mar 2009 18:00:02 +0100 (CET) Received: by ewy20 with SMTP id 20so2227740ewy.45 for ; Tue, 03 Mar 2009 09:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=iYfSZmJoawQOJSmBXO2GYQvZJKyPWtxlOqK7qm6W4OQ=; b=rrK6gI6XzFHNTojLrElK8qJUsxHOfgrDpUlfmargwl6wc7KFDo0ECIzEVdacDUxYcQ 97Hz+je+dUaqL/yYQgg30+NDhG63L5c/QTXDaxIdTrjTgxlvpsw+Pju2w4KLwzm6onFc EMxQADZ0MK89o3ITBc15t6zjLAN94pibOyFM4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=ceNs7G2g/2W6tNs+t/W6u1uE80onL/mJuxlaAMEjgSf8/yrAzt67PIN9XhFg9fjb/w TZHNRFNpS0LIQWWk6/Ye5keN96WXexMW2vWQnR2ZHFwUTwub2/EFPKlisiZq/+c8gE6L L9mA0uc2XN/wZbxxDdA1U8mNRO2OazvUe5qAI= MIME-Version: 1.0 Received: by 10.210.61.11 with SMTP id j11mr4319875eba.29.1236099601983; Tue, 03 Mar 2009 09:00:01 -0800 (PST) In-Reply-To: <200903031655.n23Gt97v023747@news01.csr.com> References: <20090303121253.61f5e2ec@news01> <20090303163526.533995be@news01> <237967ef0903030851gc26620ficfc908628a4b3be2@mail.gmail.com> <200903031655.n23Gt97v023747@news01.csr.com> Date: Tue, 3 Mar 2009 18:00:01 +0100 Message-ID: <237967ef0903030900x2976851cv86aa44206fbb006a@mail.gmail.com> Subject: Re: [wip patch] new zsh/attr module From: Mikael Magnusson To: zsh workers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.92.1/9065/Tue Mar 3 11:43:41 2009 on bifrost X-Virus-Status: Clean 2009/3/3 Peter Stephenson : > Mikael Magnusson wrote: >> > don't report errors unless system calls returned a negative value >> >> I know the codestyle is a bit questionable but I already check 0 < len >> in the first if, so the else will be all negative lengths already. > > ... or zero, which was the problem. It was printing an error message > with errno 0 if the list returned empty. It now does the standard > Unix-style thing of printing nothing but returning status zero. Uh, right. I must have left my head somewhere else :). -- Mikael Magnusson