zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: PATCH: caps strings
Date: Tue, 3 Mar 2009 19:00:50 +0100	[thread overview]
Message-ID: <237967ef0903031000x26b129e6kb0ef5d7eb8cfd134@mail.gmail.com> (raw)
In-Reply-To: <237967ef0903030955l1bbe4224p9d3f4a2bf1d04c77@mail.gmail.com>

2009/3/3 Mikael Magnusson <mikachu@gmail.com>:
> 2009/3/3 Peter Stephenson <pws@csr.com>:
>> This should fix string arguments to functions in the caps module as
>> noticed by Mikael.  It looks like all the returned strings are output
>> directly by library calls so aren't affected.
>>
> I think the two zwarnnam calls with *argv needs them to be
> re-metafy()ed. When i didn't do that in attr.c, I got output like
> myutf8file\M-p.

Ie,

diff --git a/Src/Modules/cap.c b/Src/Modules/cap.c
index 4242d44..3fb653b 100644
--- a/Src/Modules/cap.c
+++ b/Src/Modules/cap.c
@@ -72,11 +72,12 @@
     do {
 	char *result = NULL;
 	ssize_t length;
+	unmetafy(*argv, NULL);
 	cap_t caps = cap_get_file(*argv);
 	if(caps)
 	    result = cap_to_text(caps, &length);
 	if (!caps || !result) {
-	    zwarnnam(nam, "%s: %e", *argv, errno);
+	    zwarnnam(nam, "%s: %e", metafy(*argv, slen, META_NOALLOC), errno);
 	    ret = 1;
 	} else
 	    printf("%s %s\n", *argv, result);
@@ -101,7 +102,7 @@
     do {
 	unmetafy(*argv, NULL);
 	if(cap_set_file(*argv, caps)) {
-	    zwarnnam(nam, "%s: %e", *argv, errno);
+	    zwarnnam(nam, "%s: %e", metafy(*argv, slen, META_NOALLOC), errno);
 	    ret = 1;
 	}
     } while(*++argv);


-- 
Mikael Magnusson


  reply	other threads:[~2009-03-03 18:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 17:43 Peter Stephenson
2009-03-03 17:55 ` Mikael Magnusson
2009-03-03 18:00   ` Mikael Magnusson [this message]
2009-03-03 18:10   ` Peter Stephenson
2009-03-03 18:21     ` Mikael Magnusson
2009-03-03 18:31       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237967ef0903031000x26b129e6kb0ef5d7eb8cfd134@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).