From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1615 invoked from network); 3 Mar 2009 18:21:57 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 3 Mar 2009 18:21:57 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 85288 invoked from network); 3 Mar 2009 18:21:53 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 3 Mar 2009 18:21:53 -0000 Received: (qmail 10108 invoked by alias); 3 Mar 2009 18:21:48 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26681 Received: (qmail 10096 invoked from network); 3 Mar 2009 18:21:48 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 3 Mar 2009 18:21:48 -0000 Received: from mail-ew0-f172.google.com (mail-ew0-f172.google.com [209.85.219.172]) by bifrost.dotsrc.org (Postfix) with ESMTP id 565178058F82 for ; Tue, 3 Mar 2009 19:21:44 +0100 (CET) Received: by ewy20 with SMTP id 20so2270710ewy.45 for ; Tue, 03 Mar 2009 10:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=ioE2VTadQsLH4no7eF1FJdGCr/M5rL+CC08vw99mkG4=; b=dnGu4L/4Wtd8GASpPdgteFqbolUn7l7NOZbXcSSMWNrf/tTzu5Y8jMrJTFIk9+BtIc EpBkFREJD4rSnl2/5GvnlT8hCP8NhGqlr4eOJjY7Bvv2CwojgMWCeRvk5giPwKbfrsaX lLlwYInzu1MBrtPawolQgD71mxqs25o8yUn+0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=LSIPQDN0RIzgXXoXI73d9IH8Y8n/ooZV3FmCBhR9SDAULmPRto4dpxvvp1qxYxFUXW F9In1HAI5Gy2r4B4rAaUjfwBcCv8fxmxfhwa4ekwC9t4CP6vmd8JFnIMeLzWd3EjOuVQ oIg3y5tKLXawRXF2TkaeZyfXECJrUcm5ut528= MIME-Version: 1.0 Received: by 10.210.13.9 with SMTP id 9mr4578679ebm.10.1236104504045; Tue, 03 Mar 2009 10:21:44 -0800 (PST) In-Reply-To: <20090303181056.3ec33006@news01> References: <27480.1236102218@csr.com> <237967ef0903030955l1bbe4224p9d3f4a2bf1d04c77@mail.gmail.com> <20090303181056.3ec33006@news01> Date: Tue, 3 Mar 2009 19:21:44 +0100 Message-ID: <237967ef0903031021yf6632adhd399c06289ff6ddc@mail.gmail.com> Subject: Re: PATCH: caps strings From: Mikael Magnusson To: Zsh hackers list Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.92.1/9065/Tue Mar 3 11:43:41 2009 on bifrost X-Virus-Status: Clean 2009/3/3 Peter Stephenson : > On Tue, 3 Mar 2009 18:55:30 +0100 > Mikael Magnusson wrote: >> I think the two zwarnnam calls with *argv needs them to be >> re-metafy()ed. When i didn't do that in attr.c, I got output like >> myutf8file\M-p. > > Index: Src/Modules/cap.c > =================================================================== > RCS file: /cvsroot/zsh/zsh/Src/Modules/cap.c,v > retrieving revision 1.8 > diff -u -r1.8 cap.c > --- Src/Modules/cap.c 3 Mar 2009 17:46:51 -0000 1.8 > +++ Src/Modules/cap.c 3 Mar 2009 18:09:50 -0000 > @@ -72,7 +72,10 @@ > do { > char *result = NULL; > ssize_t length; > - cap_t caps = cap_get_file(*argv); > + cap_t caps; > + char *filename; Where did this variable come from? > + > + caps = cap_get_file(unmetafy(dupstring(*argv), NULL)); > if(caps) > result = cap_to_text(caps, &length); > if (!caps || !result) { > @@ -99,8 +102,7 @@ > } > > do { > - unmetafy(*argv, NULL); > - if(cap_set_file(*argv, caps)) { > + if(cap_set_file(unmetafy(dupstring(*argv, NULL)), caps)) { > zwarnnam(nam, "%s: %e", *argv, errno); > ret = 1; > } Does dupstring somehow allocate from the stack? Should I use it instead of re-metafy()ing in attr.c too, or maybe it doesn't really matter which you do? -- Mikael Magnusson