From: Mikael Magnusson <mikachu@gmail.com>
To: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH 2/4] attr: Make zlistattr return an array, zdelattr takeseveral attrs
Date: Thu, 5 Nov 2009 10:48:05 +0100 [thread overview]
Message-ID: <237967ef0911050148i3d236ac5vc9d0a419c38e3ad8@mail.gmail.com> (raw)
In-Reply-To: <a06001014c718258a35df@kba.biglobe.ne.jp>
2009/11/5 Jun T. <takimoto-j@kba.biglobe.ne.jp>:
> "zdelattr file attr1 attr2" deletes only attr2.
>
> Index: Src/Modules/attr.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
> retrieving revision 1.4
> diff -u -r1.4 attr.c
> --- Src/Modules/attr.c 4 Nov 2009 11:34:03 -0000 1.4
> +++ Src/Modules/attr.c 5 Nov 2009 05:17:33 -0000
> @@ -154,7 +154,7 @@
> {
> int ret = 0, slen;
> int symlink = OPT_ISSET(ops, 'h');
> - char *file = argv[0], **attr = &argv[1];
> + char *file = argv[0], **attr = argv;
>
> unmetafy(file, &slen);
> while (*++attr) {
Oops, I must have changed two things at once, I remember finding that
bug and fixing it. I must have broken it again after that. Thanks.
--
Mikael Magnusson
next prev parent reply other threads:[~2009-11-05 9:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 21:55 [wip patch] new zsh/attr module Mikael Magnusson
2009-02-26 22:36 ` Mikael Magnusson
2009-02-27 0:48 ` Mikael Magnusson
2009-03-03 12:12 ` Peter Stephenson
2009-03-03 14:43 ` Mikael Magnusson
2009-03-03 16:35 ` Peter Stephenson
2009-03-03 16:51 ` Mikael Magnusson
2009-03-03 16:55 ` Peter Stephenson
2009-03-03 17:00 ` Mikael Magnusson
2009-11-03 18:52 ` Mikael Magnusson
2009-11-03 18:55 ` [PATCH 1/4] attr: add -h option to operate on symlinks without dereferencing Mikael Magnusson
2009-11-04 10:48 ` Peter Stephenson
2009-11-04 11:01 ` Mikael Magnusson
2009-11-04 11:36 ` Peter Stephenson
2010-09-12 11:12 ` Mikael Magnusson
2009-11-03 18:56 ` [PATCH 2/4] attr: Make zlistattr return an array, zdelattr take several attrs Mikael Magnusson
2009-11-05 6:51 ` [PATCH 2/4] attr: Make zlistattr return an array, zdelattr takeseveral attrs Jun T.
2009-11-05 9:48 ` Mikael Magnusson [this message]
2009-11-03 18:57 ` [PATCH 3/4] attr: dynamically allocate memory for attributes Mikael Magnusson
2009-11-03 18:57 ` [PATCH 4/4] attr: Use descriptive variables for argv and allow setting values with embedded nuls Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237967ef0911050148i3d236ac5vc9d0a419c38e3ad8@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).