From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-27352-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 24282 invoked by alias); 5 Nov 2009 09:48:24 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 27352
Received: (qmail 19770 invoked from network); 5 Nov 2009 09:48:11 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.5
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 74.125.78.144 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:cc:content-type;
        bh=R2PyZtES93pHTeMLaz8q5+N6lR0FGSj8nTPkZZEOrAQ=;
        b=LbK6JrS5elMpufaLTXknGqQRVCCZTxUd5p7BLA/V2EhJfX2R73ryQvLkMhL8TW0BR6
         jxzuFZsSAjlOrTL+Kt/2ut281AUmIS0h5o303XNNxrPhHzhoE/NXqLOEQnpRrOzYquHW
         UOL5IDcwi8D2Lz7vd1lJHNoe0p4ARGIky7WQo=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=Z3mWY/MiFLg5xfDBrogBjKmidKEC0SyiO3SXJ2mZkKJmrzCNaqvQxn4I/h2Mwt9fYp
         nfjbVFD1qrxXHNJ36lF1/EO9pSWMRf2E+VoYijJPaoqUo3OkDt7JHLLDD2thsB47bdVd
         m8C7N7Ag/BPL9ynxlrEik61iTZzaXSnKQoLyQ=
MIME-Version: 1.0
In-Reply-To: <a06001014c718258a35df@kba.biglobe.ne.jp>
References: <alpine.LNX.2.00.0902262245590.27571@localhost>
	 <20090303121253.61f5e2ec@news01>
	 <alpine.LNX.2.00.0903031455360.10365@localhost>
	 <20090303163526.533995be@news01>
	 <237967ef0903030851gc26620ficfc908628a4b3be2@mail.gmail.com>
	 <alpine.LNX.2.00.0911031955490.3783@localhost>
	 <a06001014c718258a35df@kba.biglobe.ne.jp>
Date: Thu, 5 Nov 2009 10:48:05 +0100
Message-ID: <237967ef0911050148i3d236ac5vc9d0a419c38e3ad8@mail.gmail.com>
Subject: Re: [PATCH 2/4] attr: Make zlistattr return an array, zdelattr 
	takeseveral attrs
From: Mikael Magnusson <mikachu@gmail.com>
To: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

2009/11/5 Jun T. <takimoto-j@kba.biglobe.ne.jp>:
> "zdelattr file attr1 attr2" deletes only attr2.
>
> Index: Src/Modules/attr.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
> retrieving revision 1.4
> diff -u -r1.4 attr.c
> --- Src/Modules/attr.c  4 Nov 2009 11:34:03 -0000       1.4
> +++ Src/Modules/attr.c  5 Nov 2009 05:17:33 -0000
> @@ -154,7 +154,7 @@
>  {
>     int ret = 0, slen;
>     int symlink = OPT_ISSET(ops, 'h');
> -    char *file = argv[0], **attr = &argv[1];
> +    char *file = argv[0], **attr = argv;
>
>     unmetafy(file, &slen);
>     while (*++attr) {

Oops, I must have changed two things at once, I remember finding that
bug and fixing it. I must have broken it again after that. Thanks.

-- 
Mikael Magnusson