Re: Quoting problems with _zip (unzip) completer

[Mikael Magnusson <mikachu@gmail.com>]

On 17 August 2009 21:58, Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> On Tue, 04 Aug 2009 09:50:59 +0100
> Peter Stephenson <pws@csr.com> wrote:
>> Mikael Magnusson wrote:
>> > % unzip test\[.zip <tab>
>> > _zip:117: bad pattern: test[.zip(|.zip|.ZIP)
>> > _zip:117: bad pattern: test[.zip(|.zip|.ZIP)
>> > _zip:117: bad pattern: test[.zip(|.zip|.ZIP)
>>
>> ... the value of "line" [in _zip] is a bit inconsistent.  Sure
>> enough if I use ~/tmp/zip/tmp\[.zip $line[1] comes back (using print -r) as
>>
>>   ~/tmp/zip/test[.zip
>>
>> which is wrong---either the ~ needs to be expanded, or the [ needs to be
>> quoted.  So this needs tracking internally, unfortunately.  If it hits
>> the internal completion quoting system we're probably stuck---I spent
>> weeks looking at that a couple of years ago and got virtually nowhere.
>> However, it may not be that bad in this case.
>
> It's inside comparguments, but luckily in only one place.  This removes
> the internal unquoting so the form above works.
>
> This could easily have knock-on effects in other callers of _arguments,
> however they should be fixable by simple local changes (and at least
> one case, the one above, works without updating, so others probably do,
> too), while with the old code there were unfixable cases, so I think we
> just need to identify them and change them as they come up.
>
> So please watch out for any anomalous _arguments quoting behaviour.

Hm, I can't remember if this fixed my original problem of not being
able to complete after unzip test\[.zip, if it did, something seems to
have broken it again. I do still have it in my "zsh-unfixed" dir so I
think it didn't. I don't get any errors, but I also don't get any
completions. (I actually encountered it when completing zdelattr,
which for some reason also uses $~, ah, you added that for me ;).

Long story short, if it was never fixed, never mind, I just want to
know if I'm getting senile. :)

--
Mikael Magnusson