From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: zsh-workers@zsh.org
Subject: Re: PATCH: _fc: Remove a spurious 2
Date: Tue, 21 Apr 2015 00:24:08 +0200 [thread overview]
Message-ID: <24507.1429568648@thecus.kiddle.eu> (raw)
In-Reply-To: <1429372196-6153-1-git-send-email-mikachu@gmail.com>
Mikael Magnusson wrote:
> AFAICS, -2 isn't an option more than any other number is, and this broke
> history -<tab> completion.
That 2 is not spurious. It excludes the second argument, i.e. the
_arguments specification '2:last event:->events'
You can only have one argument after -m.
I think completion for history (as opposed to fc) is broken for quite a
different reason, see the following patch.
Oliver
diff --git a/Completion/Zsh/Command/_fc b/Completion/Zsh/Command/_fc
index 1331456..c298721 100644
--- a/Completion/Zsh/Command/_fc
+++ b/Completion/Zsh/Command/_fc
@@ -49,7 +49,7 @@ fc_r='(-A -R -W -I -e)-l[list resulting commands on stdout]'
case $service in
history)
- _arguments "$fc_common[@]" "$fc_hist[@] && ret=0"
+ _arguments "$fc_common[@]" "$fc_hist[@]" && ret=0
;;
r)
_arguments "$fc_common[@]" "$fc_r" && ret=0
prev parent reply other threads:[~2015-04-20 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 15:49 Mikael Magnusson
2015-04-20 22:24 ` Oliver Kiddle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24507.1429568648@thecus.kiddle.eu \
--to=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).