From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34940-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 8878 invoked by alias); 20 Apr 2015 22:30:06 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34940
Received: (qmail 2033 invoked from network); 20 Apr 2015 22:29:53 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1429568649; bh=n58Ex0PdkCfVRr9Yr4QZXr5BfO1j7Ohoe6MPgpv2mFo=; h=To:In-reply-to:From:References:Subject:Date:From:Subject; b=Qc+aERFLiDPxcpwvyD2dgv6pEveTNdHUcnEgrxftHNC1DTJN1OfOE0TjMyMJm0oEFaOMgvo9M0qrK4Ay2HHPocIbOgVQ2bneScceBwAaSBlt0+F0Y4vT0W212XuuyQfXAxYcCXiNbcU4com2ZsyXUQHOK9VmpU+kPf60dtEa1cDIdbdqUE3Vxeagv0GVqZi5swZoCOPNztKSnsG9jcSk7qO7bkEl0qtndJbkmmiL3ZK5+K33wEuBV1m/2qp/Z0dPqh6pmtpgtTHODsTX551aAhJBhOTXzTVPuvGFzbcXPdiJ/lya9LBB4yKkAnaVUe1nWzu7BRwaxWa9WHKJE4KwjA==
X-Yahoo-Newman-Id: 21402.61011.bm@smtp131.mail.ir2.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: cnKQgp8VM1nRBw8dkrsSnTynwNJzQ5r2fxk.RouckNqvBPk
 JUst8HyWFDPkr5ERsVdFfyx9_ngM5LNq11y37oisqBfWRL5T045DPHJjMmUb
 Xp8rJUN.nZYOqaHPUbD4W3fKOAnhiOOEuBXdjZeXMxi.HG89cIGzIm..foMQ
 BfAvPQm5LgyTdZRc__FGq1IOXJFl20toLfLVJ6VlAjcayjtFsfKXvw8qobh5
 QtuBJD8cp8IZx7HSm3O4oLq1HIx.Crdo2VM4KM_2tTAuGU0aaLAzE7hSdKAu
 SOoKcmxeUusFODb2BskBznlzF.COyYfADoUmYtX4cHGkaCDmyOUac7LWPb3o
 1exT_.NKrg_xYSI276Fn..1FhWYJa6YZrdptZ5KGhZ5BXak3rZXmbFDKn3LG
 YZrbKe6N23vsAVzClN594NxNUoLFdU_jCDlySulqEGXYpKfr24HoDhz.KZWo
 QnWZNyXu_EnNMJItn5KA8iboSWKsCpMl2Gf3vr09KMQDpPGlGHMaUf7KyMef
 P0eVZMQMMopgdcCYVOAyoucIxMRQLaRcw
X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI-
To: zsh-workers@zsh.org
In-reply-to: <1429372196-6153-1-git-send-email-mikachu@gmail.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <1429372196-6153-1-git-send-email-mikachu@gmail.com>
Subject: Re: PATCH: _fc: Remove a spurious 2
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24505.1429568636.1@thecus.kiddle.eu>
Date: Tue, 21 Apr 2015 00:24:08 +0200
Message-ID: <24507.1429568648@thecus.kiddle.eu>

Mikael Magnusson wrote:
> AFAICS, -2 isn't an option more than any other number is, and this broke
> history -<tab> completion.

That 2 is not spurious. It excludes the second argument, i.e. the
_arguments specification '2:last event:->events'
You can only have one argument after -m.

I think completion for history (as opposed to fc) is broken for quite a
different reason, see the following patch.

Oliver

diff --git a/Completion/Zsh/Command/_fc b/Completion/Zsh/Command/_fc
index 1331456..c298721 100644
--- a/Completion/Zsh/Command/_fc
+++ b/Completion/Zsh/Command/_fc
@@ -49,7 +49,7 @@ fc_r='(-A -R -W -I -e)-l[list resulting commands on stdout]'
 
 case $service in
   history)
-    _arguments "$fc_common[@]" "$fc_hist[@] && ret=0"
+    _arguments "$fc_common[@]" "$fc_hist[@]" && ret=0
   ;;
   r)
     _arguments "$fc_common[@]" "$fc_r" && ret=0