From: Zefram <zefram@dcs.warwick.ac.uk>
To: pws@ifh.de (Peter Stephenson)
Cc: zsh-workers@math.gatech.edu
Subject: Re: big key binding patch
Date: Mon, 25 Nov 1996 16:02:40 +0000 (GMT) [thread overview]
Message-ID: <24676.199611251602@stone.dcs.warwick.ac.uk> (raw)
In-Reply-To: <199611251322.OAA26377@hydra.ifh.de> from "Peter Stephenson" at Nov 25, 96 02:22:20 pm
>This key binding overhaul was certainly necessary.
It certainly was, Stanley.
>the str Key element doesn't get set to null in addkeybindentry(),
>causing `already free' error messages later. However, is the
>zfree(cur->str) immediately after the addkeybindentry() in
>bin_bindkey() still required? It's not quite clear to me since the
>test at the end of addkeybindentry() is different (and so is the free,
>but that must be essentially cosmetic).
Urgh. I'm planning another patch, after the next release, which among
other things will clean up this area of bin_bindkey() quite a bit.
>There's also some not-bugs with uninitialized variables that gcc complains
>about which I've fixed anyway (that's the current policy, not clear
>how necessary it really is but it eliminates a source of complaints).
Yes, I wonder why those didn't show up when I first compiled the new code.
>I still had -pedantic turned on when I first compiled this and gcc
>doesn't like having to initialise the keybindtab elements of list[] in
>unbindzlefunc() at load time. That probably needs fixing (if there
>are any genuinely pedantic compilers around) but I couldn't think of a
>portable fix without more verbose code.
That'll teach me to assume that someone else was mistaken. The code I
replaced had HashTable *'s in that list, and extra dereferences.
-zefram
next prev parent reply other threads:[~1996-11-25 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-11-24 15:30 Zefram
1996-11-25 13:22 ` Peter Stephenson
1996-11-25 16:02 ` Zefram [this message]
1996-11-25 18:57 ` Thorsten Meinecke
1996-11-25 22:05 ` Zefram
1996-11-26 8:46 ` Zefram
1996-11-26 12:03 Duncan Sinclair
1996-11-26 12:10 ` Zefram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24676.199611251602@stone.dcs.warwick.ac.uk \
--to=zefram@dcs.warwick.ac.uk \
--cc=pws@ifh.de \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).