From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4779 invoked from network); 1 Apr 2004 09:11:31 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 1 Apr 2004 09:11:31 -0000 Received: (qmail 6596 invoked by alias); 1 Apr 2004 09:11:12 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 19716 Received: (qmail 6549 invoked from network); 1 Apr 2004 09:11:12 -0000 Received: from localhost (HELO sunsite.dk) (127.0.0.1) by localhost with SMTP; 1 Apr 2004 09:11:12 -0000 X-MessageWall-Score: 0 (sunsite.dk) Received: from [130.225.247.86] by sunsite.dk (MessageWall 1.0.8) with SMTP; 1 Apr 2004 9:11:12 -0000 Received: (qmail 18651 invoked from network); 1 Apr 2004 09:11:11 -0000 Received: from mail36.messagelabs.com (193.109.254.211) by a.mx.sunsite.dk with SMTP; 1 Apr 2004 09:11:09 -0000 X-VirusChecked: Checked X-Env-Sender: okiddle@yahoo.co.uk X-Msg-Ref: server-22.tower-36.messagelabs.com!1080810641!5097910 X-StarScan-Version: 5.2.10; banners=-,-,- X-Originating-IP: [158.234.9.163] Received: (qmail 9869 invoked from network); 1 Apr 2004 09:10:41 -0000 Received: from iris.logica.co.uk (158.234.9.163) by server-22.tower-36.messagelabs.com with SMTP; 1 Apr 2004 09:10:41 -0000 Received: from trentino.logica.co.uk ([158.234.142.61]) by iris.logica.co.uk (8.12.3/8.12.3/Debian -4) with ESMTP id i319AfCk017645; Thu, 1 Apr 2004 10:10:41 +0100 Received: from trentino.logica.co.uk (localhost [127.0.0.1]) by trentino.logica.co.uk (Postfix) with ESMTP id BF7DF79250F3; Thu, 1 Apr 2004 11:09:56 +0200 (CEST) Cc: zzapper , zsh-workers@sunsite.dk, cygwin@cygwin.com X-VirusChecked: Checked X-StarScan-Version: 5.0.7; banners=.,-,- In-reply-to: From: Oliver Kiddle References: <1vvf60l9i7n4nlobcroik2le5ofe6v2rn4@4ax.com> <3372.1080639122@trentino.logica.co.uk> <2603.1080737128@trentino.logica.co.uk> To: "Peter A. Castro" Subject: Re: zsh and line breaks Date: Thu, 01 Apr 2004 11:09:56 +0200 Message-ID: <25057.1080810596@trentino.logica.co.uk> X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63 X-Spam-Hits: 0.0 "Peter A. Castro" wrote: > > It is easy for us to add `#ifdef __CYGWIN__' around changes or #define > > O_TEXT to zero on other systems so if you do correct the problem, > > please send the changes back to us. > > There are about 43 open() calls which I've updated with the O_TEXT > option. Having all those ifdef's seemed rather ugly (makes the code hard > to look at, expectially when they are within a few lines of each other) > so I took a more "elegent" approach, though you may want to revise it if > it doesn't meet your style requirements :) I can believe that adding ifdef's to all is ugly. That's what I meant by "#define O_TEXT to zero on other systems" - just one thought on a possible more "elegant" approach. > Yep, I'm experimenting with this right now. As it stands, tests which > print out to a file and then cat it back in (currently A04redirect and > E01options) produce a diff, but don't otherwise seem to have any > problems. Are the diffs just the line endings? From what I understand, the reported problems were with text files used as input to the shell (i.e. scripts, sourced files, autoloaded functions and stdin). Quite whether it is also right for redirected output, I wouldn't know. Oliver