zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: dana <dana@dana.is>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Fix inaccuracies in _brace_parameter completion wording
Date: Sat, 07 Oct 2017 22:50:31 +0200	[thread overview]
Message-ID: <25350.1507409431@thecus.kiddle.eu> (raw)
In-Reply-To: <CA+_8RBA1eGWvYqPZpD8mc7nJwdWO7CXi6x+_EK01UrteEGaPnA@mail.gmail.com>

dana wrote:
> The _brace_parameter completion function indicates that the expansion flags
> B, E, M, and R can be used with the ${foo/bar/baz} syntax. According to the
> documentation (zshexpn), this is not so:

Thanks for this. I've applied the patch.

Looking at that function the description for :? also looks wrong - the
sense is inverted.

Oliver

diff --git a/Completion/Zsh/Context/_brace_parameter b/Completion/Zsh/Context/_brace_parameter
index f22db8895..e1e9adc41 100644
--- a/Completion/Zsh/Context/_brace_parameter
+++ b/Completion/Zsh/Context/_brace_parameter
@@ -195,7 +195,7 @@ elif compset -P '*:'; then
       '+:substitute alternate value if parameter is non-null'
       '=:substitute and assign alternate value if parameter is null'
       '\:=:unconditionally assign value to parameter'
-      '?:print error if parameter is set and non-null'
+      '?:print error if parameter is null'
       '#:filter value matching pattern'
       '/:replace whole word matching pattern'
       '|:set difference'


      reply	other threads:[~2017-10-07 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-07  7:44 dana
2017-10-07 20:50 ` Oliver Kiddle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25350.1507409431@thecus.kiddle.eu \
    --to=okiddle@yahoo.co.uk \
    --cc=dana@dana.is \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).