zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: Zsh 3 and ${1+"$@"} (Was: [GNU Autoconf 2.53] testsuite.log: 126 failures)
Date: Tue, 09 Apr 2002 12:30:12 +0100	[thread overview]
Message-ID: <25364.1018351812@csr.com> (raw)
In-Reply-To: "Peter Stephenson"'s message of "Tue, 09 Apr 2002 11:35:43 BST." <28727.1018348543@csr.com>

Peter Stephenson wrote:
> I think the problem you are running across is that with the option
> SH_WORD_SPLIT set (as it is for sh compatibility), you get this behaviour:
> 
> % set 'one two'
> % for arg in ${1+"$@"}; do echo $arg; done
> one
> two
> 
> whereas you expect `one two' on the same line.  This problem is still in
> zsh 4 --- inside another substitution, either it's splitting all words
> on spaces, or it's splitting none.

(For zsh-workers only.)

By the way, I'm sure this is horribly incomplete at best --- and
paramsubst() is too grotesque for me to understand it --- but, just so I
understand what is going on, what is the problem with (deliberately
expanded the context):

Index: Src/subst.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/subst.c,v
retrieving revision 1.30
diff --unified=10 -r1.30 subst.c
--- Src/subst.c	22 Feb 2002 17:28:06 -0000	1.30
+++ Src/subst.c	9 Apr 2002 11:27:09 -0000
@@ -1478,20 +1478,22 @@
 		val = dupstring(s);
 		/*
 		 * This is not good enough for sh emulation!  Sh would
 		 * split unquoted substrings, yet not split quoted ones
 		 * (except according to $@ rules); but this leaves the
 		 * unquoted substrings unsplit, and other code below
 		 * for spbreak splits even within the quoted substrings.
 		 */
 		multsub(&val, (aspar ? NULL : &aval), &isarr, NULL);
 		copied = 1;
+		if (spbreak == 1)
+		    spbreak = 0;
 	    }
 	    break;
 	case ':':
 	    if (*s != '=' && *s != Equals)
 		goto noclosebrace;
 	    vunset = 1;
 	    s++;
 	    /* Fall through */
 	case '=':
 	case Equals:

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************


  parent reply	other threads:[~2002-04-09 11:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200204081534.g38FYlY0058635@epicenter.eas.purdue.edu>
2002-04-09  9:45 ` Akim Demaille
2002-04-09 10:35   ` Peter Stephenson
2002-04-09 10:51     ` Akim Demaille
2002-04-09 11:05       ` Peter Stephenson
2002-04-09 11:18       ` Bart Schaefer
2002-04-09 11:45       ` Oliver Kiddle
2002-04-09 11:59         ` Peter Stephenson
2002-04-10 15:52           ` Akim Demaille
2002-04-10 15:54             ` A Braunsdorf
2002-04-10 17:33               ` Akim Demaille
2002-04-10 20:41                 ` A Braunsdorf
2002-04-10 17:09             ` Paul Eggert
2002-04-10 17:32               ` Akim Demaille
2002-04-09 11:30     ` Peter Stephenson [this message]
2002-04-09 16:34       ` Bart Schaefer
2002-04-09 16:45         ` Peter Stephenson
2002-04-09 18:09           ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25364.1018351812@csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).