Re: Completion function for bitkeeper?

Re: Completion function for bitkeeper?

[Oliver Kiddle]

Bart wrote:

> } > Word splitting is vastly different in the two cases.  It happens within
> } > the words of $action in the second case, but does not in the first case.
> 
> That's a bit incoherent, let me try again.

That makes more sense now. Not sure I'd describe it as "vastly
different". It would only affect fairly unusual cases.

> In this second case it's a syntax error.  I suppose it could be argued
> that the second case is unnecessary because it's only a shorthand for
> the first case with only one command in the braces.

Do you really think it's worth keeping both syntaxes though given that
it'd be nice to simplify _arguments syntax a little. I'd still be
inclined to deprecate the initial space form but I'm really not so
fussed. 

> Also in the second case the eval has been factored out of the loop
> because we're always interested in the entire value of "$action" and
> it's fractionally more efficient to do the "eval" once only.

Though it is fairly rare for label loops to run more than once.
 
Oliver

Re: Completion function for bitkeeper?

[Peter Stephenson]

Danek Duvall wrote:
> I still maintain that passing in the compadd arguments both on the
> commandline and in $expl is a bug, as it's duplicative, redundant,
> repetitive, and redundant.

But at least it doesn't do the same thing twice over again once more...

About the only alternative is to hold the values in a fixed array or
(preferably) associative array and allow functions to grope around in it.
That would eliminate the explicit expl which crops up everywhere.
However, it would need setting and unsetting for each function where
expl is currently local.  I suspect it needs lower level help to do it
neatly.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************