From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26910 invoked from network); 7 Apr 2005 16:05:07 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 7 Apr 2005 16:05:07 -0000 Received: (qmail 37883 invoked from network); 7 Apr 2005 16:05:01 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 7 Apr 2005 16:05:01 -0000 Received: (qmail 4193 invoked by alias); 7 Apr 2005 16:04:56 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21107 Received: (qmail 4169 invoked from network); 7 Apr 2005 16:04:54 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 7 Apr 2005 16:04:54 -0000 Received: (qmail 37525 invoked from network); 7 Apr 2005 16:04:54 -0000 Received: from mail36.messagelabs.com (193.109.254.211) by a.mx.sunsite.dk with SMTP; 7 Apr 2005 16:04:44 -0000 X-VirusChecked: Checked X-Env-Sender: okiddle@yahoo.co.uk X-Msg-Ref: server-22.tower-36.messagelabs.com!1112889883!0!1 X-StarScan-Version: 5.4.11; banners=-,-,- X-Originating-IP: [158.234.9.163] Received: (qmail 8034 invoked from network); 7 Apr 2005 16:04:43 -0000 Received: from iris.logica.co.uk (158.234.9.163) by server-22.tower-36.messagelabs.com with SMTP; 7 Apr 2005 16:04:43 -0000 Received: from trentino.logica.co.uk ([158.234.142.59]) by iris.logica.co.uk (8.12.3/8.12.3/Debian -4) with ESMTP id j37G4hR9021932 for ; Thu, 7 Apr 2005 17:04:43 +0100 Received: from trentino.groupinfra.com (localhost [127.0.0.1]) by trentino.logica.co.uk (Postfix) with ESMTP id 951F44AB06 for ; Thu, 7 Apr 2005 18:04:22 +0200 (CEST) X-VirusChecked: Checked X-StarScan-Version: 5.0.7; banners=.,-,- In-reply-to: <20050407144954.GN64927@dan.emsphone.com> From: Oliver Kiddle References: <200504061125.j36BP1Fs029244@news01.csr.com> <20050406212036.GA12193@fermat.math.technion.ac.il> <27939.1112860797@trentino.groupinfra.com> <20050407144954.GN64927@dan.emsphone.com> To: Zsh hackers list Subject: Re: zsh 4.2.5 Date: Thu, 07 Apr 2005 18:04:22 +0200 Message-ID: <25526.1112889862@trentino.groupinfra.com> X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 Dan Nelson wrote: > He's probably got libiconv installed and using gcc which defaults to > having /usr/local/include *before* /usr/include in the search path!! > Both sunfreeware.com's version for Solaris 9 and the one bundled with > Solaris 10 do this. Remove or rename /usr/local/include/iconv.h. Okay, so we need to find out if iconv.h comes from libiconv. That's probably easiest done by checking whether it defines _LIBICONV_H or _LIBICONV_VERSION using AC_CHECK_DECL. The following patch does that. If testing this on a suitable Solaris installation (with libiconv and gcc), note that you'll need LD_LIBRARY_PATH to contain /usr/local/lib. (otherwise the later tcsetpgrp() test fails to run because it needs to find the libiconv library). Should I perhaps use a separate ICONV_LIBS variable? Oliver Index: configure.ac =================================================================== RCS file: /cvsroot/zsh/zsh/configure.ac,v retrieving revision 1.31 diff -u -r1.31 configure.ac --- configure.ac 4 Apr 2005 09:58:49 -0000 1.31 +++ configure.ac 7 Apr 2005 16:01:02 -0000 @@ -743,6 +743,10 @@ if test "x$ac_found_iconv" != "xno"; then LIBS="-liconv $LIBS" fi + else + AC_CHECK_DECL(_libiconv_version, + [ AC_CHECK_LIB(iconv, libiconv, LIBS="-liconv $LIBS") ],, + [ #include ]) fi fi if test "x$ac_found_iconv" = xyes; then