From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from euclid.skiles.gatech.edu (list@euclid.skiles.gatech.edu [130.207.146.50]) by melb.werple.net.au (8.7.5/8.7.3) with ESMTP id IAA27605 for ; Tue, 28 May 1996 08:18:44 +1000 (EST) Received: (from list@localhost) by euclid.skiles.gatech.edu (8.7.3/8.7.3) id SAA02598; Mon, 27 May 1996 18:12:10 -0400 (EDT) Resent-Date: Mon, 27 May 1996 18:12:10 -0400 (EDT) From: Zefram Message-Id: <25534.199605272211@stone.dcs.warwick.ac.uk> Subject: Re: (NULL == 0) ? To: hzoli@cs.elte.hu (Zoltan Hidvegi) Date: Mon, 27 May 1996 23:11:48 +0100 (BST) Cc: A.Main@dcs.warwick.ac.uk, zsh-workers@math.gatech.edu In-Reply-To: <199605272200.AAA02444@hzoli.ppp.cs.elte.hu> from "Zoltan Hidvegi" at May 28, 96 00:00:42 am X-Loop: zefram@dcs.warwick.ac.uk X-Stardate: [-31]7569.62 X-US-Congress: Moronic fuckers MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Resent-Message-ID: <"7GubC1.0.We.wYYgn"@euclid> Resent-From: zsh-workers@math.gatech.edu X-Mailing-List: archive/latest/1199 X-Loop: zsh-workers@math.gatech.edu Precedence: list Resent-Sender: zsh-workers-request@math.gatech.edu >It is used to determine the size of buffers to store the string >representation of an integer. Just grep for 'SIZEOF_LONG \* 8'. If we change the `8' to `CHAR_BIT' (which will need to be determined at configuration time if there isn't a limits.h), it would be more portable. But we are assuming 8-bit bytes, as well as ASCII, in a lot of character handling code. >ntype in struct node has to be at least 32 bit long but it is defined to >int. But it would be wasting of memory to use long on systems where int >has 32 bits and long has 64. It might be wise to do a configuration check for the smallest type of at least 32 bits. There are a number of bitfields that could use this. >In hashtable.h it is assumed that sizeof(void*) >= sizeof(long). We should have a union there, as we do elsewhere. long and void * are sufficient, but it might be neater to have some other pointer types too (it would reduce casting, and would not decrease efficiency). -zefram