zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: PATCH: test for trap EXIT fix.
Date: Tue, 02 Oct 2001 16:32:44 +0100	[thread overview]
Message-ID: <25575.1002036764@csr.com> (raw)
In-Reply-To: "Bart Schaefer"'s message of "Tue, 02 Oct 2001 15:19:01 -0000." <1011002151901.ZM24646@candle.brasslantern.com>

Bart Schaefer wrote:
> On Oct 2,  3:39pm, Peter Stephenson wrote:
> } We may be able to do some special tricks with `exiting' at the end of
> } execlist(), making sure we don't exit too early from lower down in that
> } case (because of the optimization for a final command to be exec'd if
> } there's nothing left to do).  Then we just execute any top level EXIT trap
> } which has been left to us.
> 
> I'm having a hard time grokking "top level EXIT trap" in that context,
> but I think you must be thinking the right thing, because I can't find
> any other interpretation that makes sense.

`Top level' means whatever's on the front of the list of EXIT traps.  It's
about the only thing we've got we could possibly execute as a trap.  If I'm
following my own logic properly, this means

fn() {
  function TRAPEXIT { echo foo; }
  ( true )
  ( exit )
}

would execute the trap when the subshells exit (as well as when the
function exits), because the function-type trap is not deleted at the start
of the subshell, and is what we have waiting in the queue on the next exit
from anything.  This would match the behaviour the code were executed
outside the function.

The 4.0 behaviour is that only the explicit exit produces a trap; falling
off the end of the subshell in `( true )' doesn't.  I would guess this is
wrong and they should be equivalent.  That may require more special
handling.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************


  reply	other threads:[~2001-10-02 15:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-01 12:01 Peter Stephenson
2001-10-01 16:01 ` Bart Schaefer
2001-10-02 10:23   ` Peter Stephenson
2001-10-02 14:19     ` Bart Schaefer
2001-10-02 14:39       ` Peter Stephenson
2001-10-02 15:19         ` Bart Schaefer
2001-10-02 15:32           ` Peter Stephenson [this message]
2001-10-02 16:03             ` Bart Schaefer
2001-10-03 15:18               ` PATCH: (2) " Peter Stephenson
2001-10-03 16:16                 ` Bart Schaefer
2001-10-08  8:10                 ` Peter Stephenson
2001-10-08  9:56                   ` Bart Schaefer
2001-10-08 10:32                     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25575.1002036764@csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).