From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org (Zsh hackers list)
Subject: PATCH: installing executable functions
Date: Fri, 29 Jan 2010 21:54:36 +0000 [thread overview]
Message-ID: <25809.1264802076@pws-pc> (raw)
On the subject of "#!" lines, and given the general flakiness of using
the executable bit on files from CVS, wouldn't it be better and
generally more consistent to make installed functions executable if and
only if they have a #! line? If this is doing the wrong thing with a
function, then presumably the #! line is misplaced anyway.
("sed -ne '1p'" is in case there's some ghastliness where "head -1" is
broken as has occasionally been observed with "tail -1".)
The biggest disadvantage here is this could make function installation
on some systems, notably Cygwin, even more interminable. Unfortunately
we're relying on sh at this point.
Index: Config/installfns.sh
===================================================================
RCS file: /cvsroot/zsh/zsh/Config/installfns.sh,v
retrieving revision 1.14
diff -u -r1.14 installfns.sh
--- Config/installfns.sh 26 Jul 2007 08:58:08 -0000 1.14
+++ Config/installfns.sh 29 Jan 2010 21:49:56 -0000
@@ -46,7 +46,7 @@
fi
test -d $instdir || /bin/sh $sdir_top/mkinstalldirs $instdir || exit 1
$INSTALL_DATA $sdir_top/$file $instdir || exit 1
- if test -x $sdir_top/$file; then
+ if sed -ne '1p' $sdir_top/$file | grep '^#!' >/dev/null; then
chmod +x $instdir/`echo $file | sed -e 's%^.*/%%'`
fi
fi
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next reply other threads:[~2010-01-29 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 21:54 Peter Stephenson [this message]
2010-01-30 0:36 ` Bart Schaefer
2010-01-30 5:35 ` Andrey Borzenkov
2010-01-31 19:57 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25809.1264802076@pws-pc \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).