From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2b49cdd7 for ; Fri, 28 Jun 2019 08:12:42 +0000 (UTC) Received: (qmail 4491 invoked by alias); 28 Jun 2019 08:12:34 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44464 Received: (qmail 1410 invoked by uid 1010); 28 Jun 2019 08:12:33 -0000 X-Qmail-Scanner-Diagnostics: from mx1.redhat.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25489. spamassassin: 3.4.2. Clear:RC:0(209.132.183.28):SA:0(-6.9/5.0):. Processed in 2.79859 secs); 28 Jun 2019 08:12:33 -0000 X-Envelope-From: kdudka@redhat.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf1.redhat.com designates 209.132.183.28 as permitted sender) From: Kamil Dudka To: Oliver Kiddle Cc: zsh-workers@zsh.org Subject: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails Date: Fri, 28 Jun 2019 10:12:04 +0200 Message-ID: <2654381.IdzP6aUqLb@kdudka-nb> In-Reply-To: <797-1561676485.902916@C-Cf.WCnE.5Cn6> References: <20190626101908.548-1-kdudka@redhat.com> <797-1561676485.902916@C-Cf.WCnE.5Cn6> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 28 Jun 2019 08:11:55 +0000 (UTC) On Friday, June 28, 2019 1:01:25 AM CEST Oliver Kiddle wrote: > Kamil Dudka wrote: > > There is a bug report in Red Hat Bugzilla about zsh crashing on NULL > > pointer dereference: https://bugzilla.redhat.com/1722703 > > > > I was not able to reproduce the crash myself but the attached patch > > should prevent zsh from crashing in this situation. > > It'd perhaps be good to add a DPUTS call here because while it is good > not to crash the condition does perhaps indicate a bug and it'd be > better not to hide it completely. I can't reproduce the crash either but > there must be some plugins or url quoting magic going on here. > More details of the setup used by the user might help find the > underlying problem. > > Oliver Thank you for analyzing it! I do not have any more information than what is available in the mentioned bugzilla. So I asked the reporter about their setup. Kamil