From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23154 invoked from network); 5 Aug 2021 07:54:01 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Aug 2021 07:54:01 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID: Content-Type:MIME-Version:Subject:To:References:From:In-reply-to:Reply-To:Cc: Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=ROM27ooAo+ml42n34blN62XJEflTDJ72YhcjPac4BDI=; b=V89t0DDHkwQK7nMTpZGCoyQxYN fkT+4IiHDQjGGWmr5Lh1tVCrL49tm3eYH/kMXx0xtVpikhoNXrIJG1BZ7pm44gMCP3K5S0Q4+HV3Q 5wMGK9a5kYcPDu+IFIjji9Mrope0Hq3tRboZi5JLTjUPiZk3ji68nuwMqhRVO0qgp0qklfqXAXEWM nUPx9jv40jTAC5J7e97/ET4Ty7syLPtxw/DdzVgFrY2j9aSE3q6geGdaI6KZeYPMLclLW7vOrOph2 Mtk8U10QCUAm30xegUdsLvZnq1V9jnaOaga8B5m+EhAUnMSyYz3vs1tgWAUao9ZebZMo+QyZh/IPB /jaY2H9w==; Received: from authenticated user by zero.zsh.org with local id 1mBYCW-0000I8-PG; Thu, 05 Aug 2021 07:54:00 +0000 Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1mBYBx-000Py7-7M; Thu, 05 Aug 2021 07:53:25 +0000 Received: from [192.168.178.21] (helo=hydra) by mail.kiddle.eu with esmtp(Exim 4.94.2) (envelope-from ) id 1mBYBv-0006uP-Ti for zsh-workers@zsh.org; Thu, 05 Aug 2021 09:53:24 +0200 In-reply-to: <20210801162439.nfs6b7v6i2c6luqw@chazelas.org> From: Oliver Kiddle References: <20210801160547.zf37spd5ui7dfj4a@chazelas.org> <20210801162439.nfs6b7v6i2c6luqw@chazelas.org> To: Zsh hackers list Subject: Re: info completion doesn't offer index entries any longer MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26559.1628150003.1@hydra> Date: Thu, 05 Aug 2021 09:53:23 +0200 Message-ID: <26560-1628150003.918228@jgeh.uisY.RfGy> X-Seq: 49246 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 1 Aug, Stephane Chazelas wrote: > 2021-08-01 17:05:47 +0100, Stephane Chazelas: > [...] > > but even after that fixed (which causes the completion to be > > very slow on my system as That fix is needed. It looks like _call_program got added in without further testing (or a cache obscured the breakage in testing). Feel free to push the fix you described to the git repo. > > > > $ info -k '' | wc > > 47919 267467 2341131 You clearly have vastly more on your system than I have. I would guess that among that extra output is an entry or entries that need additional quoting or something and are breaking _describe - colons perhaps. > > That still doesn't give me index entries. Same with There is no actual attempt to complete anything for --index-search= What do you think we should do there? > Actually, (once fixed) it does seem to work as intended in that > it only uses the output of "info -k ''" to build a list of info > nodes that are referenced in index entries, not the index > entries themselves. > > That seems to be redundant with the parsing of info -o- that the > completer does otherwise to retrieve the list of nodes (and > which is much faster as it only covers the one manual the user > is querying completion for). I think that method only retrieves the menu for the top level of the manual. It makes more difference with some documentation than others. > Evidence of that is that fixing that "info -k" to intended "info > -k ''" doesn't seem to change much if at all the behaviour (but > makes the completion significantly slower). > > Also, caching doesn't seem to work properly as "info -k ''" > seems to be invoked every time. It does appear to work in my testing. Does the cache variable get set in your case? Again, I suspect something peculiar to the longer info -k '' output on your system is causing issues for the basic nested parameter expansion that parses the output. Oliver