From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18316 invoked by alias); 21 Feb 2017 17:28:51 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40607 Received: (qmail 6627 invoked from network); 21 Feb 2017 17:28:51 -0000 X-Qmail-Scanner-Diagnostics: from nm27-vm8.bullet.mail.ir2.yahoo.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(212.82.97.59):SA:0(-0.4/5.0):. Processed in 0.756443 secs); 21 Feb 2017 17:28:51 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: okiddle@yahoo.co.uk X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.mail.yahoo.com designates 212.82.97.59 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1487697791; bh=ViXiFmTYSTG3AGY6Poyb0dgyDbEX36RInV7FFG+8UGM=; h=cc:In-reply-to:From:References:To:Subject:Date:From:Subject; b=qrAnnkW3cnPDlgM4f3EB6qHUnlUBM29mqTDcYeO1s32lMcxrBAutYGIRtEZQ8I8VRdakQzsIW1BDtHzQUzr3W3EXPx7GkbWDsa9buTaGg5yK5X8QkGf1y6fdJaeidhXO5hfoJLXCBdPfOTCHpocx9DcRvRhNfpgo1YU4O1Gu1W/4jFSc+5PRqUgO+KeN0s9TEgXJ9FUUqKrxfGsAK6oWMofhbMfy7EbHIo+zT8908NXuNqnyeqwtJKNTyGdVzQVoBz5hjswFsHF0AG7OPEn4f/cM1r5pg8L8iSci/5/iSiG7PtFMt0cndaZMEh5rBSM3w62HkcUKMEw7Veef4NcwAQ== X-Yahoo-Newman-Id: 515965.85835.bm@smtp125.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: e_w60QcVM1mNef7gRZFXds8hd8j56owPlpmT6HyzE.DI3Dd IitFez3m25Fy.QrZW_zvr6RoyHA7tlaRIlDphNJrVj4s7UDk6fqKwOfgUwWz 2PMEphPmf4hiuPv7E8wHXeg.58.887roaDO7_p5LCcdPO0zeS3KF2Epcw0Vi 6lPq6yAw7j9jvuM4KMvLfOy1uRlJWB7sZaKiczLXbsPkX.RH2RAgXQD6C08o rZN9RQ4d7Jjx7kMg9qCYjstSJ8gyOJuplPtia5ZrXU3glzqO6J_zxHLgpdal gR039XAQ6K01plNVF8wbfC3HFdjxh1UcxeEOLlhIpuSnswwOkzdB6CgsJkha GQS8wCVc_2l5Fo11aVa9mDawAemvL9gA.uo29jTzguis3.M2ecMNXAi1Ed1w aNCPLwq9SvjhxZ8r7h0R9rwFaZgCoILvk3XSOfxaUdiG1s4GPWeMkN6dj4yi 9UfNaRedz0wkDpsG9hywoPLtSO6axA7YXpeKbeY5VxNd5_lsI2_YU2tD_i9c zH9djWLGVy8_.kS0UmZ06hayGIh6kTz8im3Pho_EhxeTQi2HRFhqZ4Mt4 X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- cc: Mailing-list zsh-workers In-reply-to: From: Oliver Kiddle References: To: Julien Nicoulaud Subject: Re: Fwd: adb pull and push remote completion MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26667.1487697790.1@thecus.kiddle.eu> Date: Tue, 21 Feb 2017 18:23:10 +0100 Message-ID: <26668.1487697790@thecus.kiddle.eu> Julien Nicoulaud wrote: > > A while ago there was a compdef for adb in https://github.com/zsh- > users/zsh-completions, but we deleted it as there was one in zsh: > https://github.com/zsh-users/zsh-completions/blob/ > e70e7f8941d7437a161e3e4bb93f06e9c712c4a4/src/_adb > > I'm not sure which one is the better one, they probably need merging, but > anyway the one in zsh-completions could complete adb push/pull. > I hope this can be useful. A cursory glance at the adb completion in zsh would indicate that, while there is plenty of scope for improvement, it is at least attempting to complete files on the remote device for push/pull. Without the requisite hardware, I can't test it and last time I touched that function I managed to accidentally break it so I'm reluctant to change it. Does it not work for you? More generally, whether or not the function in zsh is better or worse, it is the one that was contributed to zsh. Personally I'm wary of ever picking up functions from github projects and merging their features, especially where they have an explicit licence other than the zsh licence. In this case it appears that you are the author of the old function on github so you'd not have to worry. It might be possible to use the _remote_files helper when completing the files. Oliver