From: Kamil Dudka <kdudka@redhat.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: zsh-workers@zsh.org
Subject: Re: infinite recursion in ihungetc()
Date: Wed, 22 Jul 2015 16:00:10 +0200 [thread overview]
Message-ID: <2667649.zUoaYM3Kd9@kdudka.brq.redhat.com> (raw)
In-Reply-To: <20150722143803.1be07f1e@pwslap01u.europe.root.pri>
On Wednesday 22 July 2015 14:38:03 Peter Stephenson wrote:
> Yes, it should be straightforward to prevent, although this code isn't
> particularly transparent (or new), so I don't know how you could get
> there.
>
> pws
I do not know it either because these crash reports are anonymous. I will
just apply your patch to fix it and let you know if we get any feedback.
Thanks for the patch!
Kamil
> diff --git a/Src/hist.c b/Src/hist.c
> index 6725313..cf224cb 100644
> --- a/Src/hist.c
> +++ b/Src/hist.c
> @@ -136,6 +136,7 @@ mod_export int hist_skip_flags;
> #define HA_NOINC (1<<1) /* Don't store, curhist not incremented */
> #define HA_INWORD (1<<2) /* We're inside a word, don't add
> start and end markers */
> +#define HA_UNGET (1<<3) /* Recursively ungetting */
>
> /* Array of word beginnings and endings in current history line. */
>
> @@ -904,8 +905,13 @@ ihungetc(int c)
>
> while (!lexstop && !errflag) {
> if (hptr[-1] != (char) c && stophist < 4 &&
> - hptr > chline + 1 && hptr[-1] == '\n' && hptr[-2] == '\\')
> - hungetc('\n'), hungetc('\\');
> + hptr > chline + 1 && hptr[-1] == '\n' && hptr[-2] == '\\' &&
> + !(histactive & HA_UNGET)) {
> + histactive |= HA_UNGET;
> + hungetc('\n');
> + hungetc('\\');
> + histactive &= ~HA_UNGET;
> + }
>
> if (expanding) {
> zlemetacs--;
prev parent reply other threads:[~2015-07-22 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 11:45 Kamil Dudka
2015-07-22 13:38 ` Peter Stephenson
2015-07-22 14:00 ` Kamil Dudka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2667649.zUoaYM3Kd9@kdudka.brq.redhat.com \
--to=kdudka@redhat.com \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).