From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28047 invoked by alias); 12 Jun 2018 12:52:43 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42988 Received: (qmail 2734 invoked by uid 1010); 12 Jun 2018 12:52:43 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(-1.4/5.0):. Processed in 1.458843 secs); 12 Jun 2018 12:52:43 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=Sk62=I6=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1528807571; bh=vzoX7q7Ia71Zz5GAZEX+J57DebE10azTLTtGYFICi9k=; h=From:References:To:Subject:Date:From:Subject; b=i9U/F1mJMp0G1lNTZUlTCx67vLaGrR+mcIYoFZpuG9LzsgguDodX+Jk+KR5w0Y5fKi8+AfUFzz2P4b4SM0oXJf6lePE893ll7KRXN7S4MxnFpmDlAb+W2gZqsQYqUbin0A72FJpE7P/7ASJqDN8kcCqPVgJHZF/zOVZS4bqwd9aHG19hbpPBnGeakYM75njh7NvDjdz8SxD/yeLJv/Sexx+AbWlbVaHKkN13spaXUl+sGYk/6raHYgiUSdWC/x6xLkjRVpNeWl1k9ibx+tv8gStSgxAxnJ20O6jzOfZl8ly5sm4t/QVYA2l45xJEqk30EdROuqR2OdR8MvXLiXoYnw== X-YMail-OSG: DXMQX5YVM1mJkUc2fCfhrM1CaLkMbbYcX4JDKzGe1VTTdHcydXq0RYgMgtL6s67 EFgMh9L28aS1_LbQrAjclMJSBj7SE3Jj1pJUVidvOIgZ6fgrD3XhLgbpbfbtAA_T9CX_PoiavBBn jWbaL0BUpAwfW87f1TchQSHPv4_GAgHCp_PLVw7aNqeUwP4II5tqqkvHcm.NOJ_PsBSj8Tq9sAiO 9n2Erd4oMDW8_z_KPKhlS00gd5_zs0ZGNAtPsNICzjOmWUVBBDvWeCSc9VaJvXZ2LentXIW5dKSP WynVYeF3iAnNvlJN6CpJtQcLdtaMIQLyhVLalOfgWuk0rWfm0HyoqJEEtxO6ksVgUO.TD_Z_6T4Q fuCVP9XDkfKVWf46zxLYU9qF39MITuZmRbyj8ENomQpg54fCnR5xpe3qhlqhzDkDQhufvaNWo3gG M294ADKTJSm6xWgsOunSzqQNxDmVziAS7hvruVrRiqKpC8wNnrGdzN3ee5O7c9cA9Qkj0Z4fcGe5 jFOFe89wNB76W99LtmtosA1KT55BOQQNFnQzKPWBQTGOuUvPG.mvzlMCxDDOm3iePkPXptX2jceb uytoBGjKMUGO3aZ8eN2lpR3Ej4kNN_m8sXRrj6X5zzIOMW2l8d7ppuLUgtA6CAEIDm9xInXykyaR 1RAeNkxyeMCEoEXy7W9BPTIWgDboxrEs45_Teg0hbOQw58X_mo7v6mTsNqFWABdtifxm_nINxWea GihvU..MzGNvfhUl.TnLcf3coO4ZVdY7LV9xIcadIOKbPGZjZBHYop_nE2oSyHDc.XMwLPgbEkt0 JIzkFJdbzKNFs0EcTiwjx0ugw0tq9fKufdrdFQAXUnrN5GHgHLttGy_JYWwUhBWAiohxerC.v.OX siIgefaGDgfOIxKBg6138srhLlzYOkt.WMjoVdXDyb98V1GXBb9SNkeHc67M4oEaDqHzFdTq.cQE O9JN2m94QRFpkGgIdN979qVW9JAefGCx2Rf2BVEgjme2M1SFqLjMu0f5HaaHh cc: doron.behar@gmail.com In-reply-to: <20180609173519.q2qra4cv66u65uon@NUC.doronbehar.com> From: Oliver Kiddle References: <20180608155331.2891-1-doron.behar@gmail.com> <20180608155331.2891-2-doron.behar@gmail.com> <24170.1528475324@thecus> <20180609173519.q2qra4cv66u65uon@NUC.doronbehar.com> To: zsh-workers@zsh.org Subject: Re: [PATCH 1/1] Add completion for zathura. MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26688.1528807568.1@thecus> Date: Tue, 12 Jun 2018 14:46:08 +0200 Message-ID: <26689.1528807568@thecus> On 9 Jun, Doron Behar wrote: > I tried to get some clues as for this subject by digging into zathura's > source code (https://git.pwmt.org/pwmt/zathura). Could you please tell > me what are the files the `zathura` package (or what ever it's called) > provided under your distribution? If there are no `.so` files for at > least a PDF plugin, I'll put a fall-back here. The file list is here: https://koji.fedoraproject.org/koji/rpminfo?rpmID=4869616 That's a zathura 0.2.7 build for RHEL 7 which is perhaps somewhat old. I would strongly suggest putting a fallback in for at least *.pdf. You never know when some overly clever logic is going to fail. > That's smart but it doesn't work. Yet, after reading a little bit the > documentation I've used this instead: > > _files -g "*.{${(j.,.)supported_filetypes}}(-.)" I'd suggest sticking to pattern characters like (...|...) over brace expansion in the parameter to _files -g. If braces are working, it is by accident rather than design. > > applicable here. You probably want either _command_names -e or > > _cmdstring. > > I think I'll use `_cmdstring` since it doesn't complete aliases of > functions which probably wouldn't be interpreted properly by zathura. _cmdstring handled a quoted command-line where you might have arguments to the command. Judging from the example in the documentation, that is appropriate in this case. Oliver