building latest sources

[Oliver Kiddle <okiddle@yahoo.co.uk>]

I tried compiling the latest sources on a few of the SourceForge
compile farm machines.

On Mac OS X, it built fine. make test has one problem I couldn't work
out and I'm not sure why it failed to load zpty because I could load it
manually. The patch below suppresses a couple of compiler warnings and
adjusts _groups to use the netinfo database.

On Solaris 9, there were no problems except those caused by their
installation of GNU libiconv being found at linktime but not runtime.

NetBSD built and tested fine. I got warnings there and MacOS X for
implicit declaration of function 'ioctl'. Should we be including
sys/ioctl.h more widely?

Oliver

Index: Completion/Unix/Type/_groups
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_groups,v
retrieving revision 1.3
diff -u -r1.3 _groups
--- Completion/Unix/Type/_groups	18 Feb 2004 12:45:36 -0000	1.3
+++ Completion/Unix/Type/_groups	2 Mar 2004 18:04:35 -0000
@@ -6,7 +6,9 @@
 
 if ! zstyle -a ":completion:${curcontext}:" groups groups; then
   (( $+_cache_groups )) ||
-      if (( ${+commands[getent]} )); then
+      if [[ $OSTYPE = darwin* ]]; then
+        : ${(A)_cache_groups:=${${(M)${(f)"$(_call_program groups lookupd -q group)"}:#name*}##*: }}
+      elif (( ${+commands[getent]} )); then
         : ${(A)_cache_groups:=${${(s: :)$(_call_program groups getent group 2>/dev/null)}%%:*}}
       else
         : ${(A)_cache_groups:=${${${(s: :)$(</etc/group)}%%:*}:#+}}
Index: Src/Modules/socket.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/socket.c,v
retrieving revision 1.4
diff -u -r1.4 socket.c
--- Src/Modules/socket.c	22 May 2003 09:48:29 -0000	1.4
+++ Src/Modules/socket.c	2 Mar 2004 18:04:36 -0000
@@ -171,7 +171,7 @@
 	    tv.tv_sec = 0;
 	    tv.tv_usec = 0;
 	    
-	    if (ret = select(lfd+1, &rfds, NULL, NULL, &tv)) return 1;
+	    if ((ret = select(lfd+1, &rfds, NULL, NULL, &tv))) return 1;
 	    else if (ret == -1)
 	    {
 		zwarnnam(nam, "select error: %e", NULL, errno);
Index: Src/Modules/tcp.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.c,v
retrieving revision 1.37
diff -u -r1.37 tcp.c
--- Src/Modules/tcp.c	29 Oct 2003 19:17:48 -0000	1.37
+++ Src/Modules/tcp.c	2 Mar 2004 18:04:36 -0000
@@ -515,7 +515,7 @@
 	    tv.tv_sec = 0;
 	    tv.tv_usec = 0;
 	    
-	    if (ret = select(lfd+1, &rfds, NULL, NULL, &tv)) return 1;
+	    if ((ret = select(lfd+1, &rfds, NULL, NULL, &tv))) return 1;
 	    else if (ret == -1)
 	    {
 		zwarnnam(nam, "select error: %e", NULL, errno);
Index: Src/Zle/zle_params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_params.c,v
retrieving revision 1.12
diff -u -r1.12 zle_params.c
--- Src/Zle/zle_params.c	15 Dec 2003 22:45:29 -0000	1.12
+++ Src/Zle/zle_params.c	2 Mar 2004 18:04:36 -0000
@@ -365,7 +365,7 @@
 	free(cutbuf.buf);
     cutbuf.flags = 0;
     if (x) {
-	unmetafy(x, &cutbuf.len);
+	unmetafy(x, (int *)&cutbuf.len);
 	cutbuf.buf = zalloc(cutbuf.len);
 	memcpy((char *)cutbuf.buf, x, cutbuf.len);
 	free(x);
@@ -420,7 +420,7 @@
 	for (p = x; *p; p++) {
 	    int len = strlen(*p);
 	    kptr = kring + kpos;
-	    unmetafy(*p, &kptr->len);
+	    unmetafy(*p, (int *)&kptr->len);
 	    kptr->buf = (char *)zalloc(kptr->len);
 	    memcpy(kptr->buf, *p, kptr->len);
 	    zfree(*p, len+1);