From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _find_net_interfaces: use /sys/class/net/* for interface names in linux
Date: Tue, 11 Aug 2015 11:47:21 +0200 [thread overview]
Message-ID: <27319.1439286441@thecus.kiddle.eu> (raw)
In-Reply-To: <1439254143-4608-1-git-send-email-llua@gmx.com>
Eric Cook wrote:
> I also wasn't able to find the type of tunnels mentioned in
> http://www.zsh.org/mla/workers/2007/msg00111.html that doesn't show up
> in /proc/sys/net/ipv4/conf/. Maybe at some point since then, that was
> fixed. But to avoid some kind of regression /sys/class/net/ seems usable
> for the time being.
One example, is aliases. So if you do something like
ifconfig eth0:1 192.168.42.37
then ifconfig will show eth0:1 while /sys/class won't.
There may be cases where we don't want to complete those, however.
> diff --git a/Completion/Unix/Type/_find_net_interfaces b/Completion/Unix/Type/_find_net_interfaces
> index 0c70335..f90f310 100644
> --- a/Completion/Unix/Type/_find_net_interfaces
> +++ b/Completion/Unix/Type/_find_net_interfaces
> @@ -23,7 +23,7 @@ case $OSTYPE in
> irix*) net_intf_list=( ${${${(f)"$(/usr/etc/netstat -i)"}%% *}[2,-1]} ) ;;
> *linux*)
> if (( $+commands[ip] )); then
> - net_intf_list=( ${${(m)${(f)"$(ip -o link)"}#*: }%%: *} )
> + net_intf_list=( /sys/class/net/*(N:t) )
> fi
> ;&
The (( $+commands[ip] )) isn't really applicable after that change.
Also did you notice that we still have the following further down in the
function:
if [[ -d /proc/sys/net/ipv4/conf ]]; then
# On linux we used to use the following as the default.
# However, we now use ip or ifconfig since it finds additional devices such
# as tunnels. So only do this if that didn't work.
net_intf_list=( /proc/sys/net/ipv4/conf/*~*(all|default)(N:t) )
fi
I think the /proc path there will work for older Linux installations
than the /sys path you use and it still works with new systems.
Oliver
next prev parent reply other threads:[~2015-08-11 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 0:49 Eric Cook
2015-08-11 9:47 ` Oliver Kiddle [this message]
2015-08-11 13:27 ` Eric Cook
2015-08-12 0:25 ` Eric Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27319.1439286441@thecus.kiddle.eu \
--to=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).