From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gatech.edu (gatech.edu [130.207.244.244]) by werple.mira.net.au (8.6.12/8.6.9) with SMTP id AAA22183 for ; Thu, 13 Jul 1995 00:27:51 +1000 Received: from math (math.skiles.gatech.edu) by gatech.edu with SMTP id AA20853 (5.65c/Gatech-10.0-IDA for ); Wed, 12 Jul 1995 10:22:20 -0400 Received: by math (5.x/SMI-SVR4) id AA12449; Wed, 12 Jul 1995 10:17:35 -0400 Resent-Date: Wed, 12 Jul 1995 15:18:08 +0100 (BST) Old-Return-Path: From: Zefram Message-Id: <27330.199507121418@stone.dcs.warwick.ac.uk> Subject: Re: A completion bug To: hzoli@cs.elte.hu (Zoltan Hidvegi) Date: Wed, 12 Jul 1995 15:18:08 +0100 (BST) Cc: zsh-workers@math.gatech.edu (Z Shell workers mailing list) In-Reply-To: <9507121355.AA04044@turan.elte.hu> from "Zoltan Hidvegi" at Jul 12, 95 03:55:55 pm X-Loop: zefram@dcs.warwick.ac.uk X-Stardate: [-31]5967.97 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Resent-Message-Id: <"CuxQn2.0.R23.zbz0m"@math> Resent-From: zsh-workers@math.gatech.edu X-Mailing-List: archive/latest/199 X-Loop: zsh-workers@math.gatech.edu Precedence: list Resent-Sender: zsh-workers-request@math.gatech.edu -----BEGIN PGP SIGNED MESSAGE----- The patch below fixes a bug in the new completion list logic, pointed out to me by Zoltan. The symptom is that if LIST_AMBIGUOUS is unset, and an unambiguous partial completion is performed, ZLE still thinks the list is valid, which causes it to insert the unambiguous portion a second time if completion is continued. -zefram *** Src/zle_tricky.c.old Wed Jul 12 15:08:36 1995 --- Src/zle_tricky.c Wed Jul 12 15:09:25 1995 *************** *** 3225,3233 **** inststrlen(firstm, 1, ab); if (ae && !atend) inststrlen(firstm + strlen(firstm) - ae, 0, ae); if (isset(LISTAMBIGUOUS) && (ab || (ae && !atend))) { lastambig = 0; - invalidatelist(); return; } } --- 3225,3234 ---- inststrlen(firstm, 1, ab); if (ae && !atend) inststrlen(firstm + strlen(firstm) - ae, 0, ae); + if(ab || (ae && !atend)) + invalidatelist(); if (isset(LISTAMBIGUOUS) && (ab || (ae && !atend))) { lastambig = 0; return; } } -----BEGIN PGP SIGNATURE----- Version: 2.6.i iQBVAgUBMAPZiGWJ8JfKi+e9AQF+SwH/X+QczHJD8FT4PWRUMWvZu23ZYdM6wAYJ r+LcJUElDlrHLoPBMk+EVQai1gbUbLYwzdAkn2Ua6MvgCKVj6AhevQ== =p+VS -----END PGP SIGNATURE-----