From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23867 invoked by alias); 6 Apr 2018 13:34:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42600 Received: (qmail 12202 invoked by uid 1010); 6 Apr 2018 13:34:14 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(-1.4/5.0):. Processed in 15.078643 secs); 06 Apr 2018 13:34:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS,T_DKIM_INVALID,T_RP_MATCHES_RCVD autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: SRS0=2XKO=G3=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1522948194; bh=SbpNM8Y6l8x+1KUNQKi/CWgg3O8wYlZu7eipEZgT/o4=; h=From:To:Subject:Date:From:Subject; b=q3GNCg5E38lH0agWMS23lBUKEeV2izPrYtJogbI8Qde8sWnRc+4nKzLJL7GeiKXrJRUGC9ehnxnBMKiDXptDbNpbBjqxveX57y8ic9cHc1uw7Og078EsURrqBRKOARO8Cs5XWe33Fp14NO/wJR2zfCXXmHn+ludGO5SoZNXx9cZoA4r/eXpiB9+rwqmtchDob7IkVIwa/+a/AjYCJLJYujOdbkLwj8VHwenwZak7oiITvlbuORbMKRKGkIH0MrkouRi/KgQelIgLEVZKh7Lb70e989SAhhJdySFdN3VP4NmDw+yOXI3yGvWMPsT5fs75f7U4eKBAJDa/pigCaBrMcA== X-YMail-OSG: Fa8u4NAVM1n0MYpTHRd6_YoX1Ee42e.JxqcYAyASLj.4XLInURfczKwMLhJKyxP fTGuI7I0C4aQEtgGrhfi66VztZuk8A_D1e9PPEQOS9hBjQQEmWh8GEk7.n2uEzLZy1GRs0UrOwvE Ado_dusJtyk3mlo.ogkDNiKInOvy6wI13JTZrvVLB5dnOYZQgIx.woNsVW3PqNJNppw.jIsKtnL. grRrkuYDgXbSQY3s3XMeen9F6KaQT_5pOcUtEua5LfCofnMNuYU_qgT6BnmjsgKqWcBEu2eweA.8 aY8TELN8zt0oM77jF.FEavkOoWtBRoLRGOQoMEOI2K2WOuqC7w6cWc8H.GRjBl3mgweVgzDLHwJq eoIH8ImFuyOIqcZ16IlXGRC7L2HuDldtE2xkZlMJ7meK.BQiahEVNGvmgZqTJ8YIZdioUk2zfa6Y LwiraZ490poW8VQqg2.PO3ATi6sJpnocI0ga4VxSzSEzn.IzsfxBAN3OymjC_SYYlZoiCpECYQbn K9urWzaN94Q-- From: Oliver Kiddle To: Zsh workers Subject: PATCH: another leak found by coverity, this one in _values MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27514.1522948186.1@thecus> Date: Thu, 05 Apr 2018 19:09:46 +0200 Message-ID: <27515.1522948186@thecus> This is in the error handling paths for _values if an exclusion list was successfully parsed but later errors occur when parsing the specs. Oliver diff --git a/Src/Zle/computil.c b/Src/Zle/computil.c index 2e86e5740..5526e0ad0 100644 --- a/Src/Zle/computil.c +++ b/Src/Zle/computil.c @@ -3022,6 +3022,7 @@ parse_cvdef(char *nam, char **args) if (hassep && !sep && name + bs + 1 < p) { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "no multi-letter values with empty separator allowed"); return NULL; } @@ -3035,6 +3036,7 @@ parse_cvdef(char *nam, char **args) if (!*p) { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "invalid value definition: %s", *args); return NULL; } @@ -3046,6 +3048,7 @@ parse_cvdef(char *nam, char **args) } if (c && c != ':') { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "invalid value definition: %s", *args); return NULL; } @@ -3054,6 +3057,7 @@ parse_cvdef(char *nam, char **args) if (c == ':') { if (hassep && !sep) { freecvdef(ret); + if (xor) freearray(xor); zwarnnam(nam, "no value with argument with empty separator allowed"); return NULL; }