From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Bug in ${(Q)...}
Date: Thu, 17 Jul 2003 10:32:14 +0100 [thread overview]
Message-ID: <27877.1058434334@csr.com> (raw)
In-Reply-To: "Bart Schaefer"'s message of "Sun, 13 Jul 2003 17:24:18 -0000." <1030713172418.ZM4800@candle.brasslantern.com>
Bart Schaefer wrote:
> On Jul 12, 7:38pm, Philippe Troin wrote:
> } Subject: Bug in ${(Q)...}
> }
> } % setopt extended_glob
> } % echo $ZSH_VERSION "<${(Q)${$(print hello)/%hello#}}>"
> } 4.0.6 < >
> }
> } Shouldn't that be:
> } 4.0.6 <>
> }
> } (no space)
>
> So I'm not sure if this is really a problem with (Q) in paramsubst(), or
> if it's deeper, in parse_subst_string(), and it just happens that (Q)
> makes it visible.
I think the fix is the following. I've never quite followed the logic
of using a string consisting only of a Nularg to represent an empty
string, but it occurs sporadically.
Index: Src/lex.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/lex.c,v
retrieving revision 1.24
diff -u -r1.24 lex.c
--- Src/lex.c 6 Oct 2002 18:38:14 -0000 1.24
+++ Src/lex.c 17 Jul 2003 09:29:06 -0000
@@ -1512,7 +1512,7 @@
{
int c, l = strlen(s), err, olen;
- if (! *s)
+ if (!*s || !strcmp(s, nulstring))
return 0;
lexsave();
untokenize(s);
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070
**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential
and/or privileged material.
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by
persons or entities other than the intended recipient is
prohibited.
If you received this in error, please contact the sender and
delete the material from any computer.
**********************************************************************
prev parent reply other threads:[~2003-07-17 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-13 2:38 Philippe Troin
2003-07-13 17:24 ` Bart Schaefer
2003-07-17 9:32 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27877.1058434334@csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).