From: pws@pwstephenson.fsnet.co.uk
To: zsh-workers <zsh-workers@sunsite.dk>
Subject: Pattern change
Date: Fri, 15 Oct 2004 11:27:34 +0200 (CEST) [thread overview]
Message-ID: <27982795.1097832454876.JavaMail.www@wwinf3006> (raw)
I'm about to commit the change suggested by Bart that treats the test string for
pattern matching by length instead of assuming null termination. It doesn't seem
worth posting the patch since it changes large chunks of the file. There's a new test
in D02glob.ztst for more complicated exclusion patterns involving paths, since
these are specially handled. All tests still pass.
Potentially this could mean we could unmetafy the string before attempting to match,
which would have advantages. However, this only makes sense if the pattern itself
uses unmetafied strings, and that's quite tricky.
Pattern matching still uses memory allocation internally in two places. First, it
uses it to copy in the start of the path for ~-exclusion. This can probably be
moved further up by using appropriate flags. Second, it uses it to avoid pathological
behaviour involving exclusions inside closures; without recording previous endpoints
of matches this can become exponentially slow. It's possible this can be improved, too,
however.
pws
--
Whatever you Wanadoo:
http://www.wanadoo.co.uk/time/
This email has been checked for most known viruses - find out more at: http://www.wanadoo.co.uk/help/id/7098.htm
next reply other threads:[~2004-10-15 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 9:27 pws [this message]
2004-10-15 10:22 pws
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27982795.1097832454876.JavaMail.www@wwinf3006 \
--to=pws@pwstephenson.fsnet.co.uk \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).