zsh-workers
 help / color / mirror / code / Atom feed
From: Kamil Dudka <kdudka@redhat.com>
To: zsh-workers@zsh.org
Subject: infinite recursion in ihungetc()
Date: Wed, 22 Jul 2015 13:45:06 +0200	[thread overview]
Message-ID: <2874073.clZcYqQZLr@kdudka.brq.redhat.com> (raw)

Fedora Analysis Framework captured 10 crashes of zsh-5.0.8 due to infinite 
recursion in ihungetc():

https://retrace.fedoraproject.org/faf/reports/717794/

The infinite recursion happens at this line:

http://repo.or.cz/w/zsh/mirror.git/blob/a0862f63:/Src/hist.c#l908

The 'hungetc' code pointer is obviously set to ihungetc() itself.  We do
not have full bakctrace of the crash but shouldn't there be any condition
to actually stop the recursion when the conditions at lines 906-907 are
true and hungetc points at ihungetc()?

There is no single command that could invalidate any of the conditions
after nesting deeper into the recursion...

Kamil


             reply	other threads:[~2015-07-22 11:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 11:45 Kamil Dudka [this message]
2015-07-22 13:38 ` Peter Stephenson
2015-07-22 14:00   ` Kamil Dudka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2874073.clZcYqQZLr@kdudka.brq.redhat.com \
    --to=kdudka@redhat.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).