From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21775 invoked by alias); 27 Jun 2015 21:40:39 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35637 Received: (qmail 24055 invoked from network); 27 Jun 2015 21:40:36 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1435440897; bh=T430f2esgaEXu8rAVwISydgAmfGy4dMO2u/zGZWZBsY=; h=In-reply-to:From:References:To:Subject:Date:From:Subject; b=t4rCs9aXPnvTG3nfX01ukJuRd5mWFC4hI/7yyNrJDNXudABbGT/FO8md1dL0rgNApouGFS9R4A756x06S2HEYMPwzn6BCE4zZrxldcJaA8npj3CHhaUpv4n9NZUz1Xb2P703pHNVa859fbpE0ZIMDHAslvZd4fx5JkmTn8WBIFViJe8qZIvmH3psGTmWPIv4kyPpp+raNwwj5S8hujabcYMEw09x10lZa+gRRAj2E07LUVAuaacv25OkZKUnWkJgCKpnV2YadyhBNUaRW0d8/WnmxTHZAjI8P9rBihpXvY8NzQo2Lbyyg/xlOhV3CGrj6vymbAT3PVkMAJ6P+78yug== X-Yahoo-Newman-Id: 699175.23843.bm@smtp102.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: LpDCtEsVM1nUNeBnN4oEUJNVUOvoOAMkPaPu06SVV65ZenF av7jAaqp5nHGp_an7LYj2a6ja5RMoRvNlzsoWZHNGRZx3iFxulOLKvXx9_bP 2CTOzMKxZsJzGOlzkSHdCVPyH541ND6N_z46N3oIQNrpZBYXSrZhx2iJD1tC JOpsw_XbtTcNefZx9.d1ezBdOy0reHO1pd8oSK4IsJ1cMKEwzNwlhhE.uIKI yIzq4in3BIedM4hQfw1FSWWJl.oo_JpGOwljv.3fbdB1vcU.g6C62_3yAStV Z9QjtAoQgvdQIO0ZdTjYtnqwYwd9XvpLZNKAQkLHHhzzkdGz2q9PsPk7HaVU dWcJEf93iWcKj4opWYY8nQFgvCI4ZTEWh_BLmMtw3OoZdkIi8DZDLc6FXJXp N4iyI_Diei3TherThYpNFSnwfyLI7rSjgATFAaD75as97BKXUSNNrCk19FRx Wcj.lUGSGh9U4MQU.6wYNSNUwlsX5rmy8VUH_VbjLqnKjc9UecKhPD59r85M lmyYMFMMx6RC9TTNY1yyuU2J6pZA4pA-- X-Yahoo-SMTP: opAkk_CswBAce_kJ3nIPlH80cJI- In-reply-to: <150627110311.ZM3603@torch.brasslantern.com> From: Oliver Kiddle References: <26732.1435387972@thecus.kiddle.eu> <150627110311.ZM3603@torch.brasslantern.com> To: Zsh workers Subject: Re: reverse-menu-complete MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <29697.1435440896.1@thecus.kiddle.eu> Date: Sat, 27 Jun 2015 23:34:56 +0200 Message-ID: <29698.1435440896@thecus.kiddle.eu> Bart wrote: > } reversemenucomplete(char **args) > } { > } wouldinstab = 0; > } + zmult = -zmult; > } + menucomplete(args); > } > } runhookdef(REVERSEMENUHOOK, NULL); > } return 0; > > So what does the REVERSEMENUHOOK do, now that the reverse_menu function > is gone? Essentially nothing. As the development guide says, "Modules can also define function hooks. Other modules can then add functions to these hooks to make the first module call these functions instead of the default." The fact that even complist didn't need to add a function to REVERSEMENUHOOK is perhaps good evidence that it isn't useful. So shall I bin it? Oliver diff --git a/Src/Zle/zle.h b/Src/Zle/zle.h index 3c65290..ab2428e 100644 --- a/Src/Zle/zle.h +++ b/Src/Zle/zle.h @@ -352,8 +352,7 @@ struct brinfo { #define BEFORECOMPLETEHOOK (zlehooks + 2) #define AFTERCOMPLETEHOOK (zlehooks + 3) #define ACCEPTCOMPHOOK (zlehooks + 4) -#define REVERSEMENUHOOK (zlehooks + 5) -#define INVALIDATELISTHOOK (zlehooks + 6) +#define INVALIDATELISTHOOK (zlehooks + 5) /* complete hook data struct */ diff --git a/Src/Zle/zle_main.c b/Src/Zle/zle_main.c index 7ccfb68..fe561fc 100644 --- a/Src/Zle/zle_main.c +++ b/Src/Zle/zle_main.c @@ -1992,8 +1992,6 @@ mod_export struct hookdef zlehooks[] = { HOOKDEF("after_complete", NULL, 0), /* ACCEPTCOMPHOOK */ HOOKDEF("accept_completion", NULL, 0), - /* REVERSEMENUHOOK */ - HOOKDEF("reverse_menu", NULL, 0), /* INVALIDATELISTHOOK */ HOOKDEF("invalidate_list", NULL, 0), }; diff --git a/Src/Zle/zle_tricky.c b/Src/Zle/zle_tricky.c index 81a2395..937b910 100644 --- a/Src/Zle/zle_tricky.c +++ b/Src/Zle/zle_tricky.c @@ -346,10 +346,7 @@ reversemenucomplete(char **args) { wouldinstab = 0; zmult = -zmult; - menucomplete(args); - - runhookdef(REVERSEMENUHOOK, NULL); - return 0; + return menucomplete(args); } /**/