From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH] Update make completion with gnu options
Date: Thu, 18 Jul 2013 00:35:05 +0900 [thread overview]
Message-ID: <29FA24CC-A523-44C7-928A-116FA209C18A@kba.biglobe.ne.jp> (raw)
In-Reply-To: <51DFA641.6080204@goots.org>
A few comments/questions on the recent patches for _make.
[1] I think the following options can be repeated
-C -I -o -W (and their --long-option versions)
and '-C' etc. should be replaced by '*-C' in option_spec.
A simple patch for this will be posted in a separate message.
With the patch,
$ make -C /foo/bar -C <tab>
will correctly complete the subdirectories of /foo/bar.
[2] Other options can't be repeated. It may be better to replace, for example,
{-B,--always-make}'[Unconditionally make all targets]'
by
'(-B --always-make)'{-B,--always-make}'[Unconditionally make all targets]'
[3] If I set
zstyle ':completion:*:descriptions' format '%B%d%b'
and complete directory after -C or -I, the description I get is not 'directory'
but 'file'. It seems that this can be 'fixed' by replacing '_file' by
'_path_files' at line 209, but I must say I haven't yet understood how/where
the description is determined.
[4] At line 156, _pick_variant is used as
_pick_variant -r is_gnu gnu=GNU unix -v -f
Why the last '-f' is necessary here?
next prev parent reply other threads:[~2013-07-17 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 6:46 Nick Cross
2013-07-12 8:38 ` Peter Stephenson
2013-07-12 23:46 ` Bart Schaefer
2013-07-13 17:00 ` Bart Schaefer
2013-07-17 15:35 ` Jun T. [this message]
2013-07-18 9:21 ` Oliver Kiddle
2013-07-18 11:44 ` Jun T.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29FA24CC-A523-44C7-928A-116FA209C18A@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).