From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-31524-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 23257 invoked by alias); 17 Jul 2013 16:23:29 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 31524
Received: (qmail 23316 invoked from network); 17 Jul 2013 16:23:22 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
Received-SPF: pass (ns1.primenet.com.au: SPF record at spf01.biglobe.ne.jp designates 133.205.19.70 as permitted sender)
X-Biglobe-Sender: <takimoto-j@kba.biglobe.ne.jp>
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: [PATCH] Update make completion with gnu options
From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
In-Reply-To: <51DFA641.6080204@goots.org>
Date: Thu, 18 Jul 2013 00:35:05 +0900
Content-Transfer-Encoding: quoted-printable
Message-Id: <29FA24CC-A523-44C7-928A-116FA209C18A@kba.biglobe.ne.jp>
References: <51DFA641.6080204@goots.org>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
X-Mailer: Apple Mail (2.1508)

A few comments/questions on the recent patches for _make.

[1] I think the following options can be repeated

   -C   -I   -o   -W  (and their --long-option versions)

and '-C' etc. should be replaced by '*-C' in option_spec.
A simple patch for this will be posted in a separate message.

With the patch,=20

   $ make -C /foo/bar -C <tab>

will correctly complete the subdirectories of /foo/bar.

[2] Other options can't be repeated. It may be better to replace, for =
example,

{-B,--always-make}'[Unconditionally make all targets]'

by

'(-B --always-make)'{-B,--always-make}'[Unconditionally make all =
targets]'

[3] If I set

zstyle ':completion:*:descriptions' format '%B%d%b'

and complete directory after -C or -I, the description I get is not =
'directory'
but 'file'. It seems that this can be 'fixed' by replacing '_file' by=20
'_path_files' at line 209, but I must say I haven't yet understood =
how/where
the description is determined.

[4] At line 156, _pick_variant is used as

_pick_variant -r is_gnu gnu=3DGNU unix -v -f

Why the last '-f' is necessary here?