From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4539 invoked from network); 9 Aug 2023 13:05:44 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 9 Aug 2023 13:05:44 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1691586344; b=WKsx50xiBuu+V1ThuOKb50GiGMPdQLpkIwWHafj34avT2CEnZa82v5cryl8w1pyaSbXb+fBQuP asGmDyJMBHiFEKlgJDDQome07xwlokgS0CZ3nZs7n5LdZGLB8e41+n4kkgYLnkPeoOgLmKyaIk BRiYfjd3fDqyDTk+XCViJ1pl4EAV4QNZACIQeYLcYAbFMmrpC3vx2K/yWgn7rZLI0iLGoo1K1y hl//sNnlWfO936VwnQ8Nkpn6x3Q3nXXyOMomsXv6bOp2SAhFypPm8K9Nl6BXzUApgh9aufo4fR Pjw0rNc6YL2Q+4HztUnyopzQUTgjyN8NDuSr2LWrhewXgg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-4316.protonmail.ch) smtp.remote-ip=185.70.43.16; dkim=pass header.d=protonmail.com header.s=protonmail3 header.a=rsa-sha256; dmarc=pass header.from=protonmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1691586344; bh=ImFbcf4rcMfntzIYfFPkC/ulAW7W1ukKM85MQ6Gyrms=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Subject:From:To:DKIM-Signature:Date: DKIM-Signature; b=dZHIX6TIt5ulsXC6x5nmqsU2Nd/fzZxH6Qf3qFrgtYeVgesS4pd6vrxoKT0n+KRtMD007uuzXN jsx9aZiC3i8SJ5c0DBIoCyJR+F6xtQu/X7NkY21oDjuLULyR23eJk+Ucnpv0x/kbeR4gWoZ9ct GTsD776em+baimO6b0jYAG3DRS059Qeu68BoqSl3XfRdoXHjdV/tWMxcL9jeGd8FCQfR/qKF9h zUstMRizrdak//RPHGRbEm5N6jKtYQdIhbpSsKMyzTu9cdi7xCTGhN98CmX9zm9D0GiTBv8fE3 hTumQcPhgwwQOKG2ktF6tPYonlSHLv3DVVMio9xn5eknzg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:From:To: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=TAGXbol0UYKKiWL9p6HQIaZw0eosQN28O8yN/ufa08E=; b=JRlA7mjE0W2E6/EaGrA0Jl/iU2 WWxhyMi7sf7BOnbHVdpMdYDukGrg10s29+21lNmbK+ISjAvI+7Tao2xfcemI5paWEEmzWw3/KhAEa /pe/syiwLc7wcnkDrKtcOWKUelJDy9MBnCRBJSno9Y2An+25wU0z1IjKrFD2GpzKDnTc7+wpxd7e5 mIKSdu8c9J/LherRdM1TnKN4n+bAuxsL7hI4KXzQ0xHGPqZMVONhtyIfmgoHag7f356LXhIDyl2/q 4OY32Q+tCt2Y8jyH/kpe7XQQLJ6xgJoVZWATRSdr7cGG2ZB+6WfdTKfDnIAEjYv+Golg4M3aUhUfG CuvrvB3Q==; Received: by zero.zsh.org with local id 1qTisg-000NwV-2R; Wed, 09 Aug 2023 13:05:42 +0000 Authentication-Results: zsh.org; iprev=pass (mail-4316.protonmail.ch) smtp.remote-ip=185.70.43.16; dkim=pass header.d=protonmail.com header.s=protonmail3 header.a=rsa-sha256; dmarc=pass header.from=protonmail.com; arc=none Received: from mail-4316.protonmail.ch ([185.70.43.16]:38461) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1qTis8-000Ndm-Px; Wed, 09 Aug 2023 13:05:09 +0000 Date: Wed, 09 Aug 2023 13:05:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1691586308; x=1691845508; bh=TAGXbol0UYKKiWL9p6HQIaZw0eosQN28O8yN/ufa08E=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=igkrnxrJT6Fh/DiZCzBIrUqZTDSFAZFGVHiaVo0nrwGRd8gazxO78bTPgE/XPt2Ff QOmm4+UARszLYyK2Y1LYigcohIHGx4GFsdYjzsb3vjUvSKR4nCpbQECefUncZg7b2e h5NmSdVevQRLAThlArvk1kQEwTal8v3g5lC1fa5/IE9gEB0kXXhRiflshsRpcHcknz PP2WJZsH7Y4TpQxcjSsXlpQ8udcO6gpnIOw1mbzhzCE7+Q8fAs9syq1dOGT0RmXfy5 GbjfLnGJkA5JquKaVQTEoM0f8aa455/uyoVc9lXkIgGwB1dmrTXjCVT+S6CxoLwKgu 55gCetya/PkRw== To: zsh-workers@zsh.org From: Wesley Subject: Re: [PATCH] Show patchlevel in version string Message-ID: <29b20e30-ab14-3f7e-494f-6702aa4a6d01@protonmail.com> In-Reply-To: <20220410213529.GD27526@tarpaulin.shahaf.local2> References: <20210903173803.4005670-1-wesley@opperschaap.net> <20220410213529.GD27526@tarpaulin.shahaf.local2> Feedback-ID: 16775156:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Seq: 52035 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On 4/10/22 17:35, Daniel Shahaf wrote: > Wesley Schwengle wrote on Fri, Sep 03, 2021 at 13:38:03 -0400: >> After this patch is applied, you get to see the following version string >> after you configured zsh with `--enable-custom-patchlevel=3D$(git descri= be)': >> >> $ ./Src/zsh --version >> zsh 5.8.0.2-dev (x86_64-pc-linux-gnu/zsh-5.8-481-g64befeb4c) > > Adding the git revision there makes sense, I suppose, but why should > this only be done when that configure option is used? The git revision > is added to ZSH_PATCHLEVEL (which is a shell variable, not an > environment variable) by default, without needing any configure flags. > > Or another perspective: CUSTOM_PATCHLEVEL is used to cause > $ZSH_PATCHLEVEL to be set to something other than its default. So, > why shouldn't the #else branch emit the default value of $ZSH_PATCHLEVEL? > > tl;dr: Why not include the (build's default) value of $ZSH_PATCHLEVEL in > the output? I missed this thread, I thought it went dead after my original submission. I didn't get the memo ;) Sorry for the delay on my part. To answer the question: Why not for all builds? I don't think regular release builds would include this. I borrowed the approach from git, although they do what you are asking. Git uses GIT-VERSION-GEN[^1] in their Makefile[^2] to include the options in their build process. I'm not all the confident with Makefile voodoo. I just thought it was handy for those who want it and my thought was that most developers have some kind of custom install zsh where they can add this logic. If you want it for every build, I would need to get some help from someone who is sufficient at Makefiles probably. I can look into it regardless. But my question is than, would the same approach as git takes be ok with you? [^1]: https://github.com/git/git/blob/master/GIT-VERSION-GEN [^2]: https://github.com/git/git/blob/master/Makefile -- Wesley Schwengle