From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 1/2] run-help: chain run-help-sudo to call run-help on the next argument
Date: Wed, 9 Dec 2020 18:05:18 +0900 [thread overview]
Message-ID: <2C69EF8B-38D6-4770-91C2-AA0959C7B9CD@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20181227152444.31608-1-me@rmz.io>
It seems we have missed two patches from Samir Benmendil.
(pointed out by Christian K, users/26216)
> 2018/12/28 0:24, Samir Benmendil <me@rmz.io> wrote:
>
> diff --git a/Functions/Misc/run-help-sudo b/Functions/Misc/run-help-sudo
> index f38696e19..a8fa7aa0f 100644
> --- a/Functions/Misc/run-help-sudo
> +++ b/Functions/Misc/run-help-sudo
> @@ -2,6 +2,6 @@
> if [ $# -eq 0 ]; then
> man sudo
> else
> - man $1
> + run-help $1
> fi
>
Can we assume that the function run-help is already loaded when run-help-sudo
is called? (I think yes, no one will use run-help-sudo without loading run-help).
If this is the case, I think the patch has no problem.
-----
Jun
prev parent reply other threads:[~2020-12-09 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 15:24 Samir Benmendil
2018-12-27 15:24 ` [PATCH 2/2] run-help: add run-help-btrfs Samir Benmendil
2020-12-09 9:14 ` Jun T
2020-12-09 15:51 ` Christian K
2020-12-11 6:08 ` Jun T
2020-12-09 9:05 ` Jun T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2C69EF8B-38D6-4770-91C2-AA0959C7B9CD@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).