From: dana <dana@dana.is>
To: zsh-workers@zsh.org
Cc: Peter Stephenson <p.stephenson@samsung.com>
Subject: Re: [PATCH] getopts: Accurately report '-x' or '+x' in error messages
Date: Fri, 1 Dec 2017 03:39:00 -0600 [thread overview]
Message-ID: <2F0DBC74-222A-4B9C-A928-6E1A7B522A0B@dana.is> (raw)
In-Reply-To: <20171201092026.269c1dcb@pwslap01u.europe.root.pri>
> Thanks, I've committed this. I'd be happy to add some getopts tests if
> you came up with any.
I did actually come up with some, though i'm slightly unsure of their quality.
How do you feel about these?
dana
diff --git a/Test/B10getopts.ztst b/Test/B10getopts.ztst
new file mode 100644
index 000000000..7eba5a4b1
--- /dev/null
+++ b/Test/B10getopts.ztst
@@ -0,0 +1,81 @@
+# Test the getopts builtin.
+
+%prep
+
+ test_getopts() {
+ local OPTARG OPTIND opt
+ local -a res
+ while getopts abc: opt 2>&1; do
+ [[ $opt == [?:] ]] || res+=( $opt )
+ done
+ (( $#res )) && print -r -- $res
+ return $(( $#res ? 0 : 1 ))
+ }
+
+%test
+
+ test_getopts
+1:no arguments
+
+ test_getopts foo
+1:one operand
+
+ test_getopts -a
+0:one option
+>a
+
+ test_getopts -a foo
+0:one option, one operand
+>a
+
+ test_getopts -a foo -b
+0:one option, two operands, leading hyphen
+>a
+
+ test_getopts -ab
+0:two options, single argument
+>a b
+
+ test_getopts -a -b
+0:two options, separate arguments
+>a b
+
+ test_getopts -a -b +a
+0:three options, + variant
+>a b +a
+
+ test_getopts -cx
+0:one option with value, single argument
+>c
+
+ test_getopts +cx
+0:one option with value, single argument, + variant
+>+c
+
+ test_getopts -c x
+0:one option with value, separate arguments
+>c
+
+ test_getopts -acx
+0:two options, one with value, single argument
+>a c
+
+ test_getopts -ac x
+0:two options, one with value, separate arguments
+>a c
+
+ test_getopts -c
+1:one option missing value
+>test_getopts:3: argument expected after -c option
+
+ test_getopts +c
+1:one option missing value, + variant
+>test_getopts:3: argument expected after +c option
+
+ test_getopts -x
+1:one illegal option
+>test_getopts:3: bad option: -x
+
+ test_getopts +x
+1:one illegal option, + variant
+>test_getopts:3: bad option: +x
next prev parent reply other threads:[~2017-12-01 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171201071310epcas1p4e06bf3264433a5d7318fbb9d6c594c18@epcas1p4.samsung.com>
2017-12-01 7:12 ` dana
2017-12-01 9:20 ` Peter Stephenson
2017-12-01 9:39 ` dana [this message]
2017-12-01 9:48 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2F0DBC74-222A-4B9C-A928-6E1A7B522A0B@dana.is \
--to=dana@dana.is \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).