zsh-workers
 help / color / mirror / code / Atom feed
From: Clinton Bunch <cdb_zsh@zentaur.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] zsh/random module [UPDATED]
Date: Thu, 24 Nov 2022 07:19:10 -0600	[thread overview]
Message-ID: <2ad1bb62-7de1-9685-54fc-56f3e3b7946f@zentaur.org> (raw)
In-Reply-To: <126127ef-2c52-ec4e-7bfe-6000ebe29bf9@bureaucracy.de>

On 11/24/2022 4:07 AM, nimaje+zml@bureaucracy.de wrote:
>
>
> On 11/24/22 03:58, Clinton Bunch wrote:
>> [snip]
>>>> +/**/
>>>> +int
>>>> +setup_(UNUSED(Module m))
>>>> +{
>>>> +#ifdef USE_URANDOM
>>>> +    /* Check for the existence of /dev/urandom */
>>>> +
>>>> +    struct stat st;
>>>> +
>>>> +    if (lstat("/dev/urandom",&st) < 0) {
>>> Why not stat()?
>> Is it appropriate for /dev/urandom to be a symlink?
>
> Yes, for example that is the case on freebsd where urandom is just a 
> symlink to random for compatibility with programs that expect urandom 
> to be there (random blocks until the randomness pool is seeded and 
> then doesn't block anymore).
On FreeBSD it doesn't use urandom, so it didn't show up in my testing.  
It only uses urandom if arc4random() or getrandom() doesn't exist
>
>>>
>>>> +    zwarn("No kernel random pool found.");
>>>> +    return 1;
>>>> +    }
>>>> +
>>>> +    if (!(S_ISCHR(st.st_mode)) ) {
>>>> +    zwarn("No kernel random pool found.");
>>>> +    return 1;
>>>> +    }
>
> So this check would be wrong on freebsd (or use random directly and 
> give an option to use urandom on systems where random starts to block 
> for some reason after being seeded, but no idea if there is a good 
> reason for random being a symlink).
On most systems random is defined to block if the randomness pool falls 
below a certain threshold until more random data is available
>
>> [snip]
>



  reply	other threads:[~2022-11-24 13:20 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 17:13 [PATCH] zsh/random module Clinton Bunch
2022-11-03 17:50 ` Bart Schaefer
2022-11-04  3:17 ` dana
2022-11-04  6:22   ` Clinton Bunch
2022-11-04  7:27     ` dana
2022-11-04 12:57       ` Clinton Bunch
2022-11-08  0:18         ` [PATCH] zsh/random module [UPDATED] Clinton Bunch
2022-11-18 14:30           ` Clinton Bunch
2022-11-19  6:42             ` Lawrence Velázquez
2022-11-18 16:23           ` Stephane Chazelas
2022-11-18 17:08             ` Clinton Bunch
2022-11-18 18:12               ` Stephane Chazelas
2022-11-18 18:38                 ` Clinton Bunch
2022-11-23 19:52                   ` Daniel Shahaf
2022-11-24 16:19                     ` Stephane Chazelas
2022-11-24 16:30                       ` Roman Perepelitsa
2022-11-24 22:39                         ` Clinton Bunch
2022-11-25  8:53                           ` Stephane Chazelas
2022-11-25  9:40                             ` Stephane Chazelas
2022-11-28 16:37                               ` further discussion of zsh/random (was [PATCH] zsh/random module [UPDATED]) Clinton Bunch
2022-11-21  1:07           ` [PATCH] zsh/random module [UPDATED] Matthew Martin
2022-11-21  1:59             ` Clinton Bunch
2022-11-21  2:21               ` Matthew Martin
2022-11-21  2:57                 ` Clinton Bunch
2022-11-21  3:14                   ` Lawrence Velázquez
2022-11-21  4:17                     ` Bart Schaefer
2022-11-21  5:05                       ` Clinton Bunch
2022-11-22 13:42                         ` dana
2022-11-23 19:49                         ` Daniel Shahaf
2022-11-22 17:44                       ` Oliver Kiddle
2022-11-22 19:48                         ` Clinton Bunch
2022-11-23  1:23                   ` Matthew Martin
2022-11-23  2:58                     ` Clinton Bunch
2022-11-23  4:14                       ` Matthew Martin
2022-11-23 13:41                         ` Clinton Bunch
2022-11-23 20:33                           ` Daniel Shahaf
2022-11-23 21:42                             ` dana
2022-11-23 23:54                               ` Daniel Shahaf
2022-11-24  0:17                                 ` Daniel Shahaf
2022-11-24  1:05                                 ` dana
2022-11-24 13:52                               ` Clinton Bunch
2022-11-23 19:46           ` Daniel Shahaf
2022-11-24  2:58             ` Clinton Bunch
2022-11-24 10:07               ` nimaje+zml
2022-11-24 13:19                 ` Clinton Bunch [this message]
2022-11-24 14:33             ` Clinton Bunch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ad1bb62-7de1-9685-54fc-56f3e3b7946f@zentaur.org \
    --to=cdb_zsh@zentaur.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).