From: "Richard Hartmann" <richih.mailinglist@gmail.com>
To: "Bart Schaefer" <schaefer@brasslantern.com>
Cc: "Zsh hackers list" <zsh-workers@sunsite.dk>
Subject: Re: Is there any interest in indentation patches?
Date: Sun, 20 Jul 2008 10:37:33 +0200 [thread overview]
Message-ID: <2d460de70807200137pfa4c315n877200c6350755cb@mail.gmail.com> (raw)
In-Reply-To: <080720010521.ZM16495@torch.brasslantern.com>
On Sun, Jul 20, 2008 at 10:05, Bart Schaefer <schaefer@brasslantern.com> wrote:
> You mean shell functions as opposed to C functions?
Yes.
> My personal preference would be that this NOT be done. It makes it
> difficult to see from one file revision to the next what's a semantic
> change and what was merely whitespace being fixed up.
Yes, that is the the one huge downside of whitespace commits.
If there was a single coding style, that one huge commit would
(possibly) be OK. That is exactly why I asked the ML.
> It's one thing if the indentation is actually so bad that it impairs
> readability -- in that case I'd be more inclined to fix it. Changing
> strictly for the sake of consistency does not seem to me worthwhile.
> To maintain it going forward, we'd have to implement a policy of
> reformatting every function that is contributed to the sources.
Once the initial effort is finished, maintaining the status quo could
be done via commit hooks and a little checker script.
Richard
prev parent reply other threads:[~2008-07-20 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 0:21 Richard Hartmann
2008-07-20 5:40 ` Andrey Borzenkov
2008-07-20 8:33 ` Richard Hartmann
2008-07-20 9:49 ` Nikolai Weibull
2008-07-20 12:17 ` Richard Hartmann
2008-07-20 16:10 ` Nikolai Weibull
2008-07-20 8:05 ` Bart Schaefer
2008-07-20 8:37 ` Richard Hartmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d460de70807200137pfa4c315n877200c6350755cb@mail.gmail.com \
--to=richih.mailinglist@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).