From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11531 invoked from network); 20 Jul 2008 08:37:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 20 Jul 2008 08:37:44 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 82887 invoked from network); 20 Jul 2008 08:37:41 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 20 Jul 2008 08:37:41 -0000 Received: (qmail 3211 invoked by alias); 20 Jul 2008 08:37:38 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25313 Received: (qmail 3199 invoked from network); 20 Jul 2008 08:37:38 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 20 Jul 2008 08:37:38 -0000 Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.241]) by bifrost.dotsrc.org (Postfix) with ESMTP id 6EFBA80561C5 for ; Sun, 20 Jul 2008 10:37:34 +0200 (CEST) Received: by an-out-0708.google.com with SMTP id b33so370026ana.13 for ; Sun, 20 Jul 2008 01:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=vBN4ssvY/cCyoyJY1ptQNv1P70L3CTyfUPaNrm0XneE=; b=JyBkxWy1S4syTywG+/pU/7kwvDT4yhVSycLwacICf5PfXgLuc1Tm3GVvCP9D1Gn3P7 esOJK6xKKzBGXgaMS5Wi5emkTSbhBrsaLRj2ng4cA7ql80j0ea+RfFMX6Fp7VrUSDA02 1gkJK0vfO0DXn2vZ33go4flwZ57MC49eXQmtA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=DT5FK2semkfrYUB82dP/03W0FIPHKzSx7olGrdzFpwtTRsWrmBWe/uS7BS+FvPNG73 7ym4HUZsXDDvYD8A8NMz5FHOMIcfrn5sGkb7au0UuArJKQBft0hyuUBjbRr8LsCmGfUM 3zHj/SuPv5gNALAh/tu6RMf6JpMrJm4Pxd+fo= Received: by 10.100.139.20 with SMTP id m20mr1224690and.135.1216543053605; Sun, 20 Jul 2008 01:37:33 -0700 (PDT) Received: by 10.100.43.19 with HTTP; Sun, 20 Jul 2008 01:37:33 -0700 (PDT) Message-ID: <2d460de70807200137pfa4c315n877200c6350755cb@mail.gmail.com> Date: Sun, 20 Jul 2008 10:37:33 +0200 From: "Richard Hartmann" To: "Bart Schaefer" Subject: Re: Is there any interest in indentation patches? Cc: "Zsh hackers list" In-Reply-To: <080720010521.ZM16495@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2d460de70807191721x683551cdifa946bf1b70e4cf7@mail.gmail.com> <080720010521.ZM16495@torch.brasslantern.com> X-Virus-Scanned: ClamAV 0.92.1/7760/Sun Jul 20 04:11:36 2008 on bifrost X-Virus-Status: Clean On Sun, Jul 20, 2008 at 10:05, Bart Schaefer wrote: > You mean shell functions as opposed to C functions? Yes. > My personal preference would be that this NOT be done. It makes it > difficult to see from one file revision to the next what's a semantic > change and what was merely whitespace being fixed up. Yes, that is the the one huge downside of whitespace commits. If there was a single coding style, that one huge commit would (possibly) be OK. That is exactly why I asked the ML. > It's one thing if the indentation is actually so bad that it impairs > readability -- in that case I'd be more inclined to fix it. Changing > strictly for the sake of consistency does not seem to me worthwhile. > To maintain it going forward, we'd have to implement a policy of > reformatting every function that is contributed to the sources. Once the initial effort is finished, maintaining the status quo could be done via commit hooks and a little checker script. Richard