[Patch] define-composed-chars mistake, additions

[Patch] define-composed-chars mistake, additions

[Benjamin R. Haskell]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 901 bytes --]

define-composed-chars had the following combination defined:

'E' + '?' = 'Ë'

The '?' is used to add tildes, though. So it should be:

'E' + ':' = 'Ë'

'Ẽ' and 'ẽ' (capital 'E' and small 'e' with tildes) are \u1ebc and \u1ebd, 
respectively. This patch moves 'Ë' to the right set of characters 
(diaeresis/umlaut) and adds 'Ẽ' and 'ẽ' to the tilde set.

'Ẽ' and 'ẽ' don't show properly in my terminal font, so, sorry if I've 
mixed anything -- the three characters in question are:

\u00cb  00cb    LATIN CAPITAL LETTER E WITH DIAERESIS
Ẽ       1ebc    LATIN CAPITAL LETTER E WITH TILDE
ẽ       1ebd    LATIN SMALL LETTER E WITH TILDE


Patch is against current CVS. I assume that's what's desired. Same with my 
having attached it (rather than inline). Please chide me if either 
assumption is wrong. I expect I'll be submitting more patches. (not just 
for this issue)

Best,
Ben

[-- Attachment #2: Type: TEXT/PLAIN, Size: 891 bytes --]

Index: Functions/Zle/define-composed-chars
===================================================================
RCS file: /cvsroot/zsh/zsh/Functions/Zle/define-composed-chars,v
retrieving revision 1.6
diff -u -p -r1.6 define-composed-chars
--- Functions/Zle/define-composed-chars	8 Dec 2008 09:47:43 -0000	1.6
+++ Functions/Zle/define-composed-chars	9 Jan 2009 07:11:21 -0000
@@ -35,7 +35,7 @@ H 124 h 125 J 134 j 135 S 15C s 15D W 17
 # tilde
 a=\?
 z[$a]="\
-A C3 E CB N D1 O D5 a E3 n F1 o F5 I 128 i 129 U 168 u 169 \
+A C3 E 1EBC N D1 O D5 a E3 e 1EBD n F1 o F5 I 128 i 129 U 168 u 169 \
 "
 # macron (d-, D- give eth)
 a=-
@@ -55,7 +55,7 @@ C 10A c 10b E 116 e 117 G 120 g 121 I 13
 # diaeresis / Umlaut
 a=:
 z[$a]="\
-A C4 I CF O D6 U DC a E4 e EB i EF o F6 u FC y FF Y 178 \
+A C4 E CB I CF O D6 U DC a E4 e EB i EF o F6 u FC y FF Y 178 \
 "
 # cedilla
 a=,

Re: [Patch] define-composed-chars mistake, additions

[Richard Hartmann]

On Fri, Jan 9, 2009 at 08:14, Benjamin R. Haskell <zsh@benizi.com> wrote:

> Patch is against current CVS. I assume that's what's desired. Same with my
> having attached it (rather than inline).

That's the correct way to do it.


> I expect I'll be submitting more patches. (not just for
> this issue)

:)


Richard

Re: [Patch] define-composed-chars mistake, additions

[Bart Schaefer]

On Jan 9, 10:18am, Richard Hartmann wrote:
} Subject: Re: [Patch] define-composed-chars mistake, additions
}
} On Fri, Jan 9, 2009 at 08:14, Benjamin R. Haskell <zsh@benizi.com> wrote:
} 
} > Patch is against current CVS. I assume that's what's desired. Same with my
} > having attached it (rather than inline).
} 
} That's the correct way to do it.

Actually in most cases I'd personally rather that the patch be inline,
unless it's really large.  It makes it easier to search for in the
zsh.org mailing list archives, and nobody seems to agree on what MIME
type to use for attached patches.

(The correct type, by the way, is "text/plain", not some bizzaro thing
that tries to explain how it's in diff format.)

Re: [Patch] define-composed-chars mistake, additions

[Richard Hartmann]

On Fri, Jan 9, 2009 at 17:01, Bart Schaefer <schaefer@brasslantern.com> wrote:

> Actually in most cases I'd personally rather that the patch be inline,
> unless it's really large.  It makes it easier to search for in the
> zsh.org mailing list archives, and nobody seems to agree on what MIME
> type to use for attached patches.

Inline stuff can be affected by line breaks and other crap, though.

If you want, I can start sending my patches both inline & attached,
though.


Richard

Re: [Patch] define-composed-chars mistake, additions

[Bart Schaefer]

On Jan 9,  5:30pm, Richard Hartmann wrote:
}
} Inline stuff can be affected by line breaks and other crap, though.

If that hasn't been a problem for the previous more than ten years,
why it is going to suddenly become a problem now?

I suppose the answer is "web-based mail clients."  Grumble.
 
} If you want, I can start sending my patches both inline & attached,
} though.

Please don't do that; it both exposes the MIME structure in the mailing
list archive *and* duplicates the information.

If you simply must use attachments, just label them text/plain, unless
they're so huge you've compressed them or some such, of course.

Re: [Patch] define-composed-chars mistake, additions

[Richard Hartmann]

On Fri, Jan 9, 2009 at 18:39, Bart Schaefer <schaefer@brasslantern.com> wrote:

> I suppose the answer is "web-based mail clients."  Grumble.

Correct. I use GVim to write my mail in GMail, but GMail
thinks it knows better than me when to break lines.Unfortunately,
its interface is the best I've seen for ML traffic, so far.


> Please don't do that; it both exposes the MIME structure in the mailing
> list archive *and* duplicates the information.
>
> If you simply must use attachments, just label them text/plain, unless
> they're so huge you've compressed them or some such, of course.

k.


Richard