From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Peter Stephenson" <p.stephenson@samsung.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] A glob with a trailing slash will now match unreadable/unexecutable directories.
Date: Mon, 13 Jan 2020 16:34:14 +0000 [thread overview]
Message-ID: <2fbb4ce0-b73b-4905-92c4-53f4c257eca2@www.fastmail.com> (raw)
In-Reply-To: <1578908793.4921.1.camel@samsung.com>
Peter Stephenson wrote on Mon, 13 Jan 2020 09:46 +00:00:
> On Mon, 2020-01-13 at 00:27 +0000, Daniel Shahaf wrote:
> > ---
> > This fixes the issue, but I'd appreciate some review.
> >
> > There are some code flow changes, but the basic idea is that instead of
> > changing "foo/" to "foo/." and calling access(), just leave it as-is and
> > call stat() and S_ISDIR() instead.
>
> Looks like that should do the trick --- next step may be to try it out
> and see if any odd edge cases turn up.
>
> Not clear if it's needed in the release since it's not a new issue.
My thoughts exactly; I'll commit to the 5.9 branch. Thanks for the review.
prev parent reply other threads:[~2020-01-13 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200113002821eucas1p2884acfad76834011d777bf81f0562c50@eucas1p2.samsung.com>
2020-01-13 0:27 ` Daniel Shahaf
2020-01-13 6:24 ` dana
2020-01-13 16:41 ` Daniel Shahaf
2020-01-13 9:46 ` Peter Stephenson
2020-01-13 16:34 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fbb4ce0-b73b-4905-92c4-53f4c257eca2@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).