From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-45295-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id ff714cab
	for <ml@inbox.vuxu.org>;
	Mon, 13 Jan 2020 16:35:27 +0000 (UTC)
Received: (qmail 13627 invoked by alias); 13 Jan 2020 16:35:19 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45295
Received: (qmail 14210 invoked by uid 1010); 13 Jan 2020 16:35:19 -0000
X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.1/25691. spamassassin: 3.4.2.  
 Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. 
 Processed in 4.230696 secs); 13 Jan 2020 16:35:19 -0000
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
X-ME-Sender: <xms:HJwcXp8Hcx3V_CmAp9rJN9QsLOgAaFYNSTcSx71PB5z3SfZ4jIO28Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdejtddgkeekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedfffgr
    nhhivghlucfuhhgrhhgrfhdfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmh
    gvqeenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgr
    fhdrnhgrmhgvnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:HJwcXsOg0ersvO_rs3A7Y4r8iThB8v3HkRWkNn8-eCaqtlhD3hYzpA>
    <xmx:HJwcXijkkj0Mdn0BuZcRrnWZUVez3xGaW6MEy8zy96L1yDC-QlDgPw>
    <xmx:HJwcXnmo4hfijzgG45I3Hx0Xz15ZOLs20aT90mP20j9EVQ7yaOLkrg>
    <xmx:HZwcXiSAqseIQssGXpymA4hZD9ORuzTxH1VT5aKic14nOpVFCl-y9Q>
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-754-g09d1619-fmstable-20200113v1
Mime-Version: 1.0
Message-Id: <2fbb4ce0-b73b-4905-92c4-53f4c257eca2@www.fastmail.com>
In-Reply-To: <1578908793.4921.1.camel@samsung.com>
References: 
 <CGME20200113002821eucas1p2884acfad76834011d777bf81f0562c50@eucas1p2.samsung.com>
 <20200113002724.12708-1-danielsh@apache.org>
 <1578908793.4921.1.camel@samsung.com>
Date: Mon, 13 Jan 2020 16:34:14 +0000
From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Peter Stephenson" <p.stephenson@samsung.com>, zsh-workers@zsh.org
Subject: =?UTF-8?Q?Re:_[PATCH]_A_glob_with_a_trailing_slash_will_now_match_unread?=
 =?UTF-8?Q?able/unexecutable_directories.?=
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

Peter Stephenson wrote on Mon, 13 Jan 2020 09:46 +00:00:
> On Mon, 2020-01-13 at 00:27 +0000, Daniel Shahaf wrote:
> > ---
> > This fixes the issue, but I'd appreciate some review.
> >=C2=A0
> > There are some code flow changes, but the basic idea is that instead=
 of
> > changing "foo/" to "foo/." and calling access(), just leave it as-is=
 and
> > call stat() and S_ISDIR() instead.
>=20
> Looks like that should do the trick --- next step may be to try it out=

> and see if any odd edge cases turn up.
>=20
> Not clear if it's needed in the release since it's not a new issue.

My thoughts exactly; I'll commit to the 5.9 branch.  Thanks for the revi=
ew.