From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: PATCH: Possible copy paste error?
Date: Tue, 28 Feb 2023 13:49:58 +0000 (GMT) [thread overview]
Message-ID: <304003971.2420768.1677592198562@mail.virginmedia.com> (raw)
In-Reply-To: <20230228133723.2945-1-mikachu@gmail.com>
> On 28/02/2023 13:37 Mikael Magnusson <mikachu@gmail.com> wrote:
> Coverity noticed that this first branch of the if statement has "meta"
> added to all the variable names except this zlecs at the end, should it?
> (I'm asking the same question)
It should be all or nothing, yes. Either the metafied version is valid
or it isn't and if it is the non-metafied version isn't currently useful.
(You might get away with it depending on what changed since conversion.)
pws
prev parent reply other threads:[~2023-02-28 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 13:37 Mikael Magnusson
2023-02-28 13:49 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304003971.2420768.1677592198562@mail.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).