From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1482 invoked from network); 28 Feb 2023 13:51:57 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 28 Feb 2023 13:51:57 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1677592317; b=JfLHgOKk//+NMDBjer8VCyQIlyjyN8dxT2cs/0u6v92/N+302+V/lqDkt1+Q3EDfb5CwzyqEBW F2CFDsLXuSZS4rq6VMSUcX/+JlUC9j2nmi7XSkwvBHZiji9IsRIyMXq/m4FQGoamoMhbupTeJ9 HF57JGiw15gv/uvevCPJDXJF8pFeNVhdLAqeYBijNarMu//1vxfNcZneZkLDFW0lS8lWZzEucj rxugf3cl9pYB4V5XdbetC4JY8ceRZQIH5BGTjw5ZFGD8HIQqT8Uyo7LDeFKvEHzo3TeckNnIGi 9BquvyOQxd8fapiN3sCp8eAMjwkbZ/ApewKaWcHqXEC1KQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (smtpq1.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.96; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1677592317; bh=DEaaeCFMm1kyr48ts6VVN/NJ3PlxfLbvTBLznkRznrw=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=IaGJEtpJOX7NzlckrgqBI3F2YYtWeoN8BuMDlCBFXNBsJtgqsvzQhDjqEpItvgF1g0phEt9QFg whJLILDdfCulpkgtUS8aYKubCfnblGIGkDJlpGV2NADK5BzPGcIMsj7OagUjB+j7POOEfHDBh0 TVTC4qlKjbLfPZVkccLw2JHAkiCOzggkB56YU2eRjC0kzFJzIfcMmpGq8pNwxQ+jaDg5f8JQYU jqKHoA+OSfo5KbRX2LBHlD+YTw/Y7Rpi43PgiKv0YgquXAlDyHD0ClM+7oX+bhO44PVVBqtmJO n8AcT3Fmwd+eIvMuSW0iTQd/mmCj3QeQNt5WL3z+JkOfaA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=S0JHNnwxK30/bXgfYPcY2xBa/dQGtI9I/moZhI2//O0=; b=ZvH6Dz6VpXXEXvlQ5svcg6tYy3 V2JjiTHx3LU0uDcFn4uBoIAuXWlTZrlSFX4e1LprNjyBs3z3gkTs+3yx3MLjoDgmAjJuPYmHB4LCk tch3qdTj6e4Cgwhd7sVgmowlHVshvgvNqAui0asQPc2ebbqg7KaT9buFR6aJruknuhB84thqnAHHi b5ZRSSTVCZ7laIqOSVjMKQk51T4bRAV5Cm80zJOjnbf7CDzJKwzyU4flC7BTGe1NXdisB8jlJGEd6 +lu2vfxjPio8OXZIMuz65FaFi1QrIDZiuZK7QLiWtFEKkYoBu9xOg9t4SBROpdffJczaV0tlb2UOQ geScsYSA==; Received: by zero.zsh.org with local id 1pX0Ob-000Clq-6U; Tue, 28 Feb 2023 13:51:57 +0000 Authentication-Results: zsh.org; iprev=pass (smtpq1.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.96; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from smtpq1.tb.ukmail.iss.as9143.net ([212.54.57.96]:34818) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1pX0Mh-000COa-DJ; Tue, 28 Feb 2023 13:50:00 +0000 Received: from [212.54.57.81] (helo=smtp2.tb.ukmail.iss.as9143.net) by smtpq1.tb.ukmail.iss.as9143.net with esmtp (Exim 4.90_1) (envelope-from ) id 1pX0Mg-0000zG-L0 for zsh-workers@zsh.org; Tue, 28 Feb 2023 14:49:58 +0100 Received: from oxbe18.tb.ukmail.iss.as9143.net ([172.25.160.149]) by smtp2.tb.ukmail.iss.as9143.net with ESMTP id X0Mgppu0u6AslX0MgpNhIh; Tue, 28 Feb 2023 14:49:58 +0100 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.149 X-CNFS-Analysis: v=2.4 cv=c8ttAzxl c=1 sm=1 tr=0 ts=63fe0686 cx=a_exe a=1lMjCg6GYPI79R2u3NWPPQ==:117 a=1DWFKdCB1IcA:10 a=IkcTkHD0fZMA:10 a=ZjyAdWuDOD4A:10 a=pGLkceISAAAA:8 a=CvIOFYDS7RfzhZoZJ-AA:9 a=QEXdDO2ut3YA:10 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1677592198; bh=DEaaeCFMm1kyr48ts6VVN/NJ3PlxfLbvTBLznkRznrw=; h=Date:From:To:In-Reply-To:References:Subject; b=6EPCPIDqkQZ29gacQkdIiPDvbkBqB/PafGxVGQJ5cfA5j7ieQFis4JU0ZX5F+/vUU bH3TZZtylRoz8BhH8BzwEcbTBC1FmR6RQC8BR4hzkQlTzQriPQcN6FPRdPvkM32Tug XTSf1PPK1OaiGFnqMAe0y9WCWt3DBJ87GwJGxuaL1jnzg4zQVr+69ulDxVJ623mWGq yzTR1dTKqcT5MTHu9fgyytGbrH3VdAHDVkZBRszINyUO4fbZWBYCNFGRAo7mp03dLv YXFsDJbSl3m0OdDj1ohw2k/RTIiiQIN3xJ+dmML4zJ5byppskP+RXQUGXcQqKD2VqV JD+V3LABsr71Q== Date: Tue, 28 Feb 2023 13:49:58 +0000 (GMT) From: Peter Stephenson To: zsh-workers@zsh.org Message-ID: <304003971.2420768.1677592198562@mail.virginmedia.com> In-Reply-To: <20230228133723.2945-1-mikachu@gmail.com> References: <20230228133723.2945-1-mikachu@gmail.com> Subject: Re: PATCH: Possible copy paste error? MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer X-Originating-IP: 147.161.224.167 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfEjHdFdcK9UXHkIL7+a3Ut/smM9rKH0oJ1y3+Ov/I5QQZce0wyEHUwsc0+UumKDV5DIXaHt5q/neR8fZ41Ux1H/aCPe1lkB3LPIeeeEc3U7PlnXxiXtM ewsxOEGW8vGunh0tKA3Jt2zl4uOJNvL+6LVMr23eeShZb2+1/9n2GyrwpjI9du3Wp1tWqyhOCTcOxETSalPPVq6QSY3E8nmdkFeRnfiB8aS8pG3jJwdE2XO2 X-Seq: 51492 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: > On 28/02/2023 13:37 Mikael Magnusson wrote: > Coverity noticed that this first branch of the if statement has "meta" > added to all the variable names except this zlecs at the end, should it? > (I'm asking the same question) It should be all or nothing, yes. Either the metafied version is valid or it isn't and if it is the non-metafied version isn't currently useful. (You might get away with it depending on what changed since conversion.) pws