From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-42739-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 8162 invoked by alias); 1 May 2018 07:49:30 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 42739
Received: (qmail 8434 invoked by uid 1010); 1 May 2018 07:49:30 -0000
X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from <SRS0=5yXd=HU=yahoo.co.uk=okiddle@bounces.park01.gkg.net>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(205.235.26.22):SA:0(-1.4/5.0):. 
 Processed in 1.241332 secs); 01 May 2018 07:49:30 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	RCVD_IN_DNSWL_NONE,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no
	version=3.4.1
X-Envelope-From: SRS0=5yXd=HU=yahoo.co.uk=okiddle@bounces.park01.gkg.net
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
X-Virus-Scanned: by amavisd-new at gkg.net
Authentication-Results: amavisd4.gkg.net (amavisd-new);
	dkim=pass (2048-bit key) header.d=yahoo.co.uk
X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1525160931; bh=Od9MBOmi8Zs6j4+2p8Bz8e0Nm+m91CW+BudfBt8UdXw=; h=From:References:To:Subject:Date:From:Subject; b=mCAaWGET3FOXuRde9K9ES5lA4/seuokdLVR6TSEHhoT02XAS0/sFKKIeBMJEJedPYKM07hov4aUAtT4/0jT+lZoRr7tWUUr0417MUW4Je/7RyAa6wgmB4m0P8TNalSHkDo9U3DDEfAhKYxL8/+bEoUc83EuZkcqFUY8+pLENVkrJut4zcHtGqLLtE8AkDUgWFjXP2Taff7chkw07ZDts3Jda7QilB8xjtoFSkCHLzBxw2i3FzHIgpC8FYvdd1AznA8DzjIhDUrcbJ9rjlYaU92XNukXOC2BlvYuEzSQmR2TXABmvuEDe33Bblu+wzX979Cr06wIClZUFdLVe/+fEdw==
X-YMail-OSG: ndo_SxsVM1m3m4EvIBUywAMom1Bl7.6ihMXYXdi5O0YQMzu7t_IJvHWe4X0F0D_
 VjrzKmJJp6vEDeJuHUk7VyQHLJUTy.8rJ6yh8zfbY7OnA0iqoZZUyPKA8kJDQFRCtwJRfIN_GBIh
 8BzD0RRFloW9Hglr_mK7ybBUl8f_ZPmnxPlS0tvOjj7fA7aRepXMvl_RG0ne8dXyDOjBDSAfPvwB
 SYUUgbg39K979FKfaWGTD6NEtuhc26euFW7X.1hTToVKQlXKJXdb6DNSsr09FEAcAhDwuzWhm2sU
 sQdhJypfjn5FSi_9A8DUtQgNtyHmh_MqzThDqViMzL7otXdvyvMy59dLLN.0qBvhaGvu7IQpaTkw
 gyO1qAFs8LSuS1YWPNLnSsAqC08JXC_iHmhY1hcLFJJTsfs1ifftQt.CnRsWJryWzjPENEFn46ct
 7gFnM3mB91cNJZLHEo7Ap3ZiNII976QEQ.Dse9D_5gI11im6HiSRGc3eEHwEWgjKKH7PY7cXFg6u
 awmoL6bLhU9qPq7pUK1HYiB.he6KcV8f0kO6QySehBbhel4G1XGfR0ffEyJ2crVV16dqfN6lribS
 .BZpuzcZzgRENCu8YTkR4jhw0Qu3_jR6E_OfPmGeXBbqSCf113vPVxk7oxaDC78OM_WL8
cc: zsh-workers@zsh.org
In-reply-to: <20180430123153.29371-1-genml+zsh-workers@thequod.de>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <20180430123153.29371-1-genml+zsh-workers@thequod.de>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Subject: Re: [PATCH] _add-zsh-hook: add -L
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30997.1525160921.1@thecus>
Date: Tue, 01 May 2018 09:48:41 +0200
Message-ID: <30998.1525160921@thecus>

Daniel Hahler wrote:
>
> --- a/Completion/Zsh/Function/_add-zsh-hook

> @@ -14,8 +14,9 @@ _add-zsh-hook() {
> -    '(-D)-d[remove HOOK from the array]' \
> -    '(-d)-D[interpret HOOK as pattern to remove from the array]' \
> +    '(-D,-L)-d[remove HOOK from the array]' \
> +    '(-d,-L)-D[interpret HOOK as pattern to remove from the array]' \
> +    '(-d,-D)-L[list current values of the array with typeset]' \

You need spaces rather commas inside the exclusion list.

I'd also convert HOOK to lowercase while you're there. Those
descriptions look like they have been copied and pasted from
documentation where full usage has been presented first - something
like:

    add-zsh-hook [ -L | -dD ] [ -Uzk ] HOOK FUNCTION

In completion, we're not presenting the information that the first
normal argument is 'HOOK'.

Oliver