From: Oliver Kiddle <opk@zsh.org>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: Completion script for the ctags program
Date: Tue, 23 Feb 2021 23:20:02 +0100 [thread overview]
Message-ID: <32617-1614118802.311486@4BXl.GCVX.2_Vl> (raw)
In-Reply-To: <1716143236.98921.1614075094353@mail2.virginmedia.com>
Peter Stephenson wrote:
> Thanks, I'm surprised we don't have one but it looks like we only have etags. I've
> submitted it.
What you've committed looks garbled with the e-mail pasted into the
middle of the function.
Indentation can be corrected when committing new functions with minimal
effort and without need to note the alteration in ChangeLog etc. I hate
doing it later because it breaks the usefulness of git blame so would
appreciate if you could make a note to do that upfront.
That said, it is better that these get applied quickly rather than
missed and forgotten. Which leads me to reconsider that I never
applied the patch in 44804 to create a separate contrib directory for
completions. I would add "suppport for only some variants of a command"
to the criteria.
That patch mainly didn't get applied because of the outstanding question
of what the directory/configure option should be named. Greg Klanderman
replied favouring 'Unsupported' or 'Unmaintained'. I think I prefer
'Contrib' because they aren't necessarily "Unmaintained" and anything
beginning with U breaks my habit of expecting C/U/C<tab> to complete the
directories there with Unix. Any other suggestions/comments on that?
Given that we need to correct the file anyway, it is probably not too
late in this case. Do you want to fix it or shall I do it when moving it
across to the "Contrib" or whatever we call it directory?
Oliver
next prev parent reply other threads:[~2021-02-23 22:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 3:11 Jacob Gelbman
2021-02-23 10:11 ` Peter Stephenson
2021-02-23 22:20 ` Oliver Kiddle [this message]
2021-02-23 22:45 ` Bart Schaefer
2021-02-23 23:51 ` Oliver Kiddle
2021-02-24 0:52 ` Bart Schaefer
2021-02-24 13:47 ` Daniel Shahaf
2021-02-23 23:05 ` Mikael Magnusson
2021-02-23 21:39 ` Oliver Kiddle
2021-02-24 4:45 ` Jacob Gelbman
2021-02-24 7:20 ` Jacob Gelbman
2021-02-24 9:26 ` Peter Stephenson
2021-02-24 14:24 ` Daniel Shahaf
2021-02-24 18:58 ` Jacob Gelbman
2021-02-24 19:01 ` Bart Schaefer
2021-03-03 20:02 ` Daniel Shahaf
2021-03-03 20:39 ` Jacob Gelbman
2021-03-03 21:40 ` Peter Stephenson
2021-03-03 22:06 ` Daniel Shahaf
2021-03-03 22:08 ` Jacob Gelbman
2021-03-03 23:28 ` Aaron Schrab
2021-03-03 23:43 ` Daniel Shahaf
2021-03-03 23:35 ` Daniel Shahaf
2021-03-07 19:18 ` Jacob Gelbman
2021-03-07 21:42 ` Daniel Shahaf
2021-03-07 21:57 ` Jacob Gelbman
2021-03-07 22:10 ` Daniel Shahaf
2021-03-11 16:15 ` Daniel Shahaf
2021-03-11 17:08 ` Jacob Gelbman
2021-03-20 1:43 ` Lawrence Velázquez
2021-03-27 16:14 ` Lawrence Velázquez
2021-03-27 20:43 ` Daniel Shahaf
2021-03-28 23:29 ` Oliver Kiddle
2021-03-29 8:54 ` Peter Stephenson
2021-03-29 15:07 ` EOL normalization? (Was: Completion script for the ctags program) Lawrence Velázquez
2021-03-29 15:34 ` Daniel Shahaf
2021-03-29 15:41 ` Lawrence Velázquez
2021-02-24 21:54 ` Completion script for the ctags program dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32617-1614118802.311486@4BXl.GCVX.2_Vl \
--to=opk@zsh.org \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).